[#5857] - Sticky to pinned
- Closed
- 22 Jan 2015
- Medium
- Build: staging
- Easy Test
- # 5857
- Diff
- brianteeman:sticky-pinned
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
in the banner manager (and isis) we have a horrible term Sticky. It is particularly horrible as the negative is unsticky which I am pretty sure is not a word.
And sometimes we use the word pinned. This PR makes it consistent to always use pinned and unpinned.
(Discussed in the en-GB user interface text group)
jissues-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Language & Strings |
| Easy | No | ⇒ | Yes |
@test works.
Note that the term sticky is also used in the PHP source code, e.g.
in controllers e.g. $this->registerTask('sticky_unpublish', 'sticky_publish');
and models, helper files, and tmpl files:
<?php echo JHtml::_('searchtools.sort', 'COM_BANNERS_HEADING_STICKY', 'a.sticky', $listDirn, $listOrder); ?>
So changing it might lead to another "Finder / Smart Search" confusion :-)
btw: I like the change to pinned and unpinned.
The term sticky remains in the column heading and in mod_banner.
There are lots of times we use a term in the code that is not matched by
the term in the strings. Unfortunately we are stuck with that for B/C.
@waader thanks I will check that
On 22 Jan 2015 08:17, "Brian Teeman" brian@teeman.net wrote:
There are lots of times we use a term in the code that is not matched by
the term in the strings. Unfortunately we are stuck with that for B/C.
And here in the ordering too.
@waader I had an issue with my repo - had to make a new PR to fix it - #5857 - should have fixed all the issues you sotted now.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5857.
Oops new PR is #5865
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5857.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-22 08:39:02 |
@test much better wording. One more tester