?
Referenced as Pull Request for: # 5869
avatar Hoffi1
Hoffi1
21 Jan 2015

Caused by a typo in FinderModelSearch::getListQuery()
line 234 should instead of
$query->where('(l.publish_start_date = ' . $nullDate . ' OR l.publish_end_date <= ' . $nowDate . ')')
be
$query->where('(l.publish_start_date = ' . $nullDate . ' OR l.publish_start_date <= ' . $nowDate . ')')
(...start... instead of ...end...)

Test:
create articles with
(1) Publish up in past and Publish down in future
(2) Publish up and down in past
(3) Publish up and down in future
(4) Publish up in past, no Publish down
(5) Publish up in future, no Publish down
and let finder find them all.
It should show (1) and (4).
But it shows (4) and (5).

avatar Hoffi1 Hoffi1 - open - 21 Jan 2015
avatar jissues-bot jissues-bot - change - 21 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 22 Jan 2015
Category Search SQL
avatar zero-24
zero-24 - comment - 22 Jan 2015

@hoffi1 can you create a pull request against staging?

If you need help please have a look into this doc page:
https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests

Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5859.
avatar Hoffi1
Hoffi1 - comment - 22 Jan 2015

@zero-24: done, PR pending. :smile:

avatar zero-24 zero-24 - change - 22 Jan 2015
Status New Closed
Closed_Date 0000-00-00 00:00:00 2015-01-22 18:56:19
Closed_By zero-24
avatar jissues-bot jissues-bot - close - 22 Jan 2015
avatar jissues-bot
jissues-bot - comment - 22 Jan 2015

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/5859

avatar zero-24
zero-24 - comment - 22 Jan 2015

Thanks so i close here as we have a PR here: #5869 Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5859.

Add a Comment

Login with GitHub to post a comment