Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5828] - Use javascript for placeholder fallback

? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
20 Jan 2015

A slight improvement on #5453 keeping the code simpler by using the html5fallback library. We use this in all fields using JForm for the same purpose. And makes more sense than using JBrowser.

avatar wilsonge wilsonge - open - 20 Jan 2015
avatar jissues-bot jissues-bot - change - 20 Jan 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 20 Jan 2015
Category ⇒ JavaScript
avatar zero-24
zero-24 - comment - 20 Jan 2015

@test success on Chrome, IE11 and IE9 (use as per HTML code placeholder)

I have no Browser wich don't support it, so i can't test the fallback.

avatar zero-24 zero-24 - test_item - 20 Jan 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 20 Jan 2015

You can test with browserstack.com and XP and ie6

On 20 January 2015 at 10:32, zero-24 notifications@github.com wrote:

@test https://github.com/test success on Chrome, IE11 and IE9 (use as
per HTML code placeholder)

I have no Browser wich don't support it, so i can't test the fallback.

—
Reply to this email directly or view it on GitHub
#5828 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 20 Jan 2015

@test Success on IE8
screen shot 2015-01-20 at 6 59 34

I like this change!
Would be perfect if we could inject the script like this
JFactory::getDocument()->addCustomTag('<!--[if lt IE 9]><script src="/media/system/js/html5fallback.js"></script><![endif]—>');

avatar zero-24 zero-24 - alter_testresult - 24 Jan 2015 - dgt41: Tested successfully
avatar zero-24
zero-24 - comment - 24 Jan 2015

@wilsonge can you have a look into @dgt41 's suggestion? So we can move this forward. Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5828.
avatar dgt41
dgt41 - comment - 24 Jan 2015

@zero-24 my suggestion is plain wrong! This PR is fine as is!

avatar zero-24 zero-24 - change - 24 Jan 2015
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 24 Jan 2015

Thanks for the update @dgt41 moving to RTC!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5828.
avatar brianteeman brianteeman - change - 24 Jan 2015
Labels Added: ?
avatar roland-d roland-d - close - 26 Jan 2015
avatar zero-24 zero-24 - close - 26 Jan 2015
avatar roland-d roland-d - change - 26 Jan 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-01-26 17:32:43
avatar ggppdk
ggppdk - comment - 31 Jan 2015

Hello, please see this issue: #5411

avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment