Feeling Lucky
?
[#5827] - target="_blank" for all links on com_postinstall
- Closed
- 10 Feb 2015
- Medium
- Build: staging
- # 5827
- Diff
- jsubri:staging
User tests: Successful: Unsuccessful:
All post-installation messages coming from joomla.org opens in a new window, PLG_TWOFACTORAUTH_TOTP_POSTINSTALL_BODY open in a new window as well, unifying behaviour on com_postinstall.
jissues-bot
- | Labels |
Added:
?
|
||
brianteeman
- comment
- 19 Jan 2015
Just to confirm that we need to use QQ for urls - they aren't needed in test but are still needed in urls
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5827.
| Category | ⇒ | Language & Strings |
brianteeman
- comment
- 27 Jan 2015
QQ is no longer needed
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5827.
jsubri
- comment
- 5 Feb 2015
Trying to resolve merge conflicts from github on windows
zero-24
- comment
- 6 Feb 2015
Trying to resolve merge conflicts from github on windows
If it don't work you can close here and open a new pull with the changes. Thanks
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-02-10 11:54:00 |
@jsubri thanks for that but github is not happy here. It think we have
merge conflictscan you have a look into it?Also IIRC we need to escape all
"with"_QQ_"So this
target="_blank"need to changed to
target="_QQ_"_blank"_QQ_"