? Success

User tests: Successful: Unsuccessful:

avatar alexvanniel
alexvanniel
15 Jan 2015

To make sure only the order[] input field is updated and not any other (hidden) input text fields, it would be best to change the selector that picks up the input field that gets the updated order.

avatar alexvanniel alexvanniel - open - 15 Jan 2015
avatar jissues-bot jissues-bot - change - 15 Jan 2015
Labels Added: ?
avatar infograf768
infograf768 - comment - 15 Jan 2015

Could you give some testing instructions using vanilla Joomla ?

avatar zero-24 zero-24 - change - 15 Jan 2015
Category JavaScript
avatar alexvanniel
alexvanniel - comment - 15 Jan 2015

Testing instructions on how to test this code change is quite simple: in com_content, com_categories or any other component that has a list view and is sortable by dragging and dropping, try to sort the order of items (you need a bootstrapped template for this in the administrator like ISIS).

Testing instructions that show how the original code will cause problems and where the proposed fix will solve this are not possible in vanilla Joomla. This is something we came across when building a very specialised component for a client of us.

The proposal is more or less a "it is a bit less messy" kind of proposal and makes the sortablelist code functioning even under "extreme" circumstances I guess.

avatar brianteeman brianteeman - change - 11 Mar 2016
Category JavaScript Fields JavaScript
avatar roland-d roland-d - change - 8 May 2016
Milestone Added:
avatar roland-d roland-d - change - 9 May 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-05-09 06:06:20
Closed_By roland-d
avatar roland-d roland-d - close - 9 May 2016
avatar roland-d roland-d - close - 9 May 2016
avatar roland-d
roland-d - comment - 9 May 2016

Merged on review. Thank you.

Add a Comment

Login with GitHub to post a comment