@test
Fine here. One more tester.

@infograf768
I am having a problem for testing this patch.

You need to make sure you use latest staging

@aasimali

The easiest way to test this here is manually change the line

If you get issues like this please check the database that you don't have more patches applyed

@infograf768 @zero-24
I directly changed the code at this path : administrator/components/com_modules/views/modules/tmpl/default.php

Successfully tested! working as expected.
Thanks @JoomliC

Thanks. Merged.

Dont you think that the Trash Icon next to the drop down should also be
changed?

If you do then that would also need to be changed in the Article Manager

On 15 January 2015 at 09:39, infograf768 notifications@github.com wrote:

Thanks. Merged.

—
Reply to this email directly or view it on GitHub
#5730 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

The trash icon next to the dropdown is here to show that the item is trashed.
It is especially useful when filter is set to All (at least in articles and other managers)

OK I see your point and it make sense but look at the tooltip

On a published icon the tooltip is a description of the status "Published
and is current"
On a trashed icon the tooltip is a description of what will happen if you
click on it "Publish Item"

(In the module manager we dont have a filter for All)

On 15 January 2015 at 10:05, infograf768 notifications@github.com wrote:

The trash icon next to the dropdown is here to show that the item is
trashed.
It is especially useful when filter is set to All (at least in articles
and other managers)
[image: screen shot 2015-01-15 at 11 04 29]
https://cloud.githubusercontent.com/assets/869724/5755565/522118f0-9ca6-11e4-8939-0a6fa1a0d236.png

—
Reply to this email directly or view it on GitHub
#5730 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

We also can add easily the Option All in the module manager

by adding line 70 of ROOT/administrator/components/com_modules/helpers/modules.php
$options[] = JHtml::_('select.option', '*', JText::_('JALL')));
would do.

As for the tooltip, this is another general issue as we have sometimes a positive action —when an item is unpublished or trashed—, sometimes a descriptive action —when an item is published.

So moving forward

1. Can you add the Option All to the module manager - its the only manager
   that could use it and doesnt have it

2. I will add tooltips to the "user interface text" working groups task
   list as you've shown its a more general problem than I thought and should
   be done globally.

OK ?

On 15 January 2015 at 10:22, infograf768 notifications@github.com wrote:

We also can add easily the Option All in the module manager

by adding line 70 of
ROOT/administrator/components/com_modules/helpers/modules.php
$options[] = JHtml::('select.option', '*', JText::('JALL')));
would do.

As for the tooltip, this is another general issue as we have sometimes a
positive action —when an item is unpublished or trashed—, sometimes a
descriptive action —when an item is published.

—
Reply to this email directly or view it on GitHub
#5730 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Will do for 1.
For 2. it may not only be a matter of Text, the descriptive tooltip when an item is published gives infos about the Current or not status of the item which is very useful. The code there is global.

1. Thanks

2. Yes agreed - we need to find a consistent way to write the tooltip
   strings. joomla/user-interface-text#38

On 15 January 2015 at 10:49, infograf768 notifications@github.com wrote:

Will do for 1.
For 2. it may not only be a matter of Text, the descriptive tooltip when
an item is published gives infos about the Current or not status of the
item which is very useful. The code there is global.

—
Reply to this email directly or view it on GitHub
#5730 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

PR to test is here:
#5735