[#5646] - Fix `$hits_class` generation for backend mod_popular
- Closed
- 15 Jan 2015
- Medium
- Build: staging
- # 5646
- Diff
- zero-24:patch-8
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR fixes the $hits_class generation for backend mod_popular
current behavior
every time the class is info
expected behavior
class should change for the hits. (red/yellow/blue)
Changes
Why we move it to red if the hits is more than 100? All my artikles have more that 100 hits (thats in that list) Maybe we need to increase the vaules?
Example
10.000 -> important
1.000 -> warning
all others -> info
$hits_class = ($hits >= 10000 ? 'important' : ($hits >= 1000 ? 'warning' : 'info'));Orginal Bug reported in german
http://www.joomlaportal.de/joomla-3-x-erweiterungen-module/316386-kleiner-bug-mod_popular.html
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Administration Modules UI/UX |
@test Tested with success.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5646.
Thanks @chmst and @richard67 moving here to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5646.
| Status | Pending | ⇒ | Ready to Commit |
Hello, I wrote the report in the German forum. Before the change, there were 4 different colors (red >0 100, yellow >= 25, blue >= 10 and gray <10). After the change, there are only 3 colors (red, yellow, blue).
It would be better with the new values to use all 4 colors.
| Labels |
Added:
?
|
||
Thanks @teccrow
I have just add gray back. zero-24@2cf23b9
Expected after the change
- >=10.000 ->
important-->red - >=1.000 ->
warning-->Yellow - =>100 ->
info-->blue - others ->
none-->gray
@teccrow can you test the last changes?
the simples way is the patchtester:
https://docs.joomla.org/Component_Patchtester_for_Testers
Just install the patchtester component (via install from URL):
https://github.com/joomla-extensions/patchtester/releases/download/2.0.beta/com_patchtester.zip
After this apply the patch via com_patchtester:
- Access the component in backend and klick the apply button for this patch (see title and ID)
- test / Review that it works.
- comment here.
see: https://www.youtube.com/watch?v=4OWgusZgIfk
Thanks. 
if I use the patch, the extension does not work anymore because the file "default.php" is empty
@teccrow as per message.
it works ok here (just tested) which version of joomla you use? I'm on 3.4-dev: http://developer.joomla.org/cms-packages/
can you revert and after this apply it again?
maybe you can try a clean install of joomla?
The test with the patch-tester does not work. The file is empty.
But when manually replacing the file everything works fine.
Thanks @teccrow moving back to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5646.
rdeutz
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-15 22:01:36 |
| Labels |
Removed:
?
|
||
Here two screenshots.
current behavior
expected/new behavior
How to test
Alternative
badge-info