Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5647] - Cleaning whitespaces from the allowed and ignored extensions array in co...

? Failure

User tests: Successful: Unsuccessful:

avatar Radek-Suski
Radek-Suski
9 Jan 2015

Cleaning whitespaces from the allowed and ignored extensions array in com_media
I think it makes sense. I am usually putting a space after a comma for better readability.

avatar Radek-Suski Radek-Suski - open - 9 Jan 2015
avatar jissues-bot jissues-bot - change - 9 Jan 2015
Labels Added: ?
avatar zero-24
zero-24 - comment - 9 Jan 2015

@Radek-Suski

yes it makes sens to me. But Travis is not happy, can you have a look into it? :smile: 

FILE: /home/travis/build/joomla/joomla-cms/libraries/cms/helper/media.php
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 5 LINE(S)
--------------------------------------------------------------------------------
 111 | ERROR | Opening parenthesis of a multi-line function call must be the
     |       | last content on the line
 111 | ERROR | No space found after comma in function call
 113 | ERROR | Closing parenthesis of a multi-line function call must be on a
     |       | line by itself
 115 | ERROR | Opening parenthesis of a multi-line function call must be the
     |       | last content on the line
 115 | ERROR | No space found after comma in function call
 117 | ERROR | Closing parenthesis of a multi-line function call must be on a
     |       | line by itself
 118 | ERROR | Functions and classes must not contain multiple empty lines in a
     |       | row; found 2 empty lines
--------------------------------------------------------------------------------
avatar Radek-Suski
Radek-Suski - comment - 9 Jan 2015

Let's see now ;)

avatar infograf768
infograf768 - comment - 9 Jan 2015

In media config we have 4 fields needing comma separated input.
Could you consider all of them?

avatar Radek-Suski
Radek-Suski - comment - 9 Jan 2015

@infograf768 Will to do today later then.
@jackkum good catch. Will check it

avatar brianteeman brianteeman - change - 9 Jan 2015
Category ⇒ Code style
avatar Kubik-Rubik Kubik-Rubik - test_item - 17 Jan 2015 - Tested successfully
avatar Kubik-Rubik
Kubik-Rubik - comment - 17 Jan 2015

Good change, I also do the same in all my extensions. One more tester please!

avatar infograf768
infograf768 - comment - 18 Jan 2015

Please let's wait for

@infograf768 Will to do today later then.

avatar Kubik-Rubik
Kubik-Rubik - comment - 18 Jan 2015

@infograf768 Radek already did the changes in his last commit! :-) IMO can be merged.

avatar Radek-Suski
Radek-Suski - comment - 18 Jan 2015

Yes. I did. Sorry, forgot to mention it.

avatar brianteeman
brianteeman - comment - 27 Jan 2015

Setting to RTC - thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5647.
avatar brianteeman brianteeman - change - 27 Jan 2015
Status Pending ⇒ Ready to Commit
avatar brianteeman brianteeman - change - 27 Jan 2015
Labels Added: ?
avatar phproberto
phproberto - comment - 7 Mar 2015

@Radek-Suski can you update this PR to fix the code style issues? I was going to send a PR against your branch but apparently it doesn't exist anymore

avatar Radek-Suski
Radek-Suski - comment - 9 Mar 2015

@phproberto I had to delete my fork. I am not really sure if I can change anything now. Or at least I have no clue how to be honest

avatar phproberto
phproberto - comment - 13 Mar 2015

I'll try to get the code from the patch and create new PR.

avatar phproberto phproberto - reference | - 13 Mar 15
avatar phproberto phproberto - change - 13 Mar 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-03-13 16:53:23
avatar phproberto phproberto - close - 13 Mar 2015
avatar phproberto phproberto - close - 13 Mar 2015
avatar phproberto phproberto - close - 13 Mar 2015
avatar phproberto phproberto - reference | - 14 Mar 15
avatar phproberto phproberto - change - 14 Mar 2015
Labels Removed: ?
avatar phproberto
phproberto - comment - 14 Mar 2015

Replaced by #6419

Add a Comment

Login with GitHub to post a comment