[#5645] - Make all Positive/Negative select boxes Button Groups
- Closed
- 15 Jan 2015
- Medium
- Build: staging
- # 5645
- Diff
- brianteeman:select
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This PR ensures that all select boxes with just two values of a type positive/negative eg show/hide are displayed as button groups and not select boxes
- Note that there are some button groups with more than 2 values eg Frontend/Administrator/Both but this is not done consistently
- Note that there are some button groups with only 2 values eg Left/Right that are displayed as button groups but this is not done consistently
@infograf768 pointed out in #5641 that the aim is to only use button groups for positive/negative values due to the green/red styling
This PR does not change anything for Notes 1 & 2 above but they should be reviewed at some point as well
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | UI/UX |
| Rel_Number | ⇒ | 5641 | |
| Relation Type | ⇒ | Pull Request for |
NOTE: Also let's remember it looks like we have inconsistencies here for the strings values: inclusive/include
I will check "author_alias_filtering_type" later today
As for Include/exclude and inclusive/exclusive they are correct those words
are not the same
On 9 January 2015 at 09:28, infograf768 notifications@github.com wrote:
NOTE: Also let's remember it looks like we have inconsistencies here for
the strings values: inclusive/include
[image: screen shot 2015-01-09 at 10 21 11]
https://cloud.githubusercontent.com/assets/869724/5677684/131896bc-97ea-11e4-8a89-49159ef73727.png—
Reply to this email directly or view it on GitHub
#5645 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Author alias filtering has been updated - good spot
@test OK
Consistency on.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5645.
| Status | Pending | ⇒ | Ready to Commit |
Moving to RTC Thanks to all!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5645.
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-15 22:03:00 |
| Labels |
Removed:
?
|
||
in modules/mod_articles_category/mod_articles_category.xml
I guess is missing same patch for "author_alias_filtering_type"