I think it's a bug.

Me too but I wanted to be sure before creating a pr

Not sure, but I think some of them might have 3 options: Hide, show and Use global. Should still be button groups though.

IIRC the decision was that if there were more than 2 options then it would
be a select

On 7 January 2015 at 22:04, Chris Davenport notifications@github.com
wrote:

Not sure, but I think some of them might have 3 options: Hide, show and
Use global. Should still be button groups though.

—
Reply to this email directly or view it on GitHub
#5641 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Okay, fair enough. The main thing is to be consistent.

exactly. The one thing I keep seeing is a default value in the xml that is
not the actual setting on a site with the test data installed ;(

On 7 January 2015 at 22:19, Chris Davenport notifications@github.com
wrote:

Okay, fair enough. The main thing is to be consistent.

—
Reply to this email directly or view it on GitHub
#5641 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Looking through the code it looks like we have cases where if there were only two options eg LTR and RTL we could have a button group or a list. There doesnt appear to be much logic in the decision which to go for

For fields that are scanning for something (like the alternate layout ones), those should probably stay a list as there isn't a defined number of options for those. In other places where there are only two options (and can only be two), I'd say making them consistent on a toggle is appropriate.

Yeah I was excluding ones that are dynamic. There are still about 30 that
seem to be arbitrary as a select. One possible reason that this was done in
some cases was because the text was long. Still not really sure thats a
valid reason.

In the Language Manager Edit Override for example there is a select box to
chose Value or Constant. It can never be anything other than those two. By
making it a Select it means two clicks to change the value.

On 7 January 2015 at 23:57, Michael Babker notifications@github.com wrote:

For fields that are scanning for something (like the alternate layout
ones), those should probably stay a list as there isn't a defined number of
options for those. In other places where there are only two options (and
can only be two), I'd say making them consistent on a toggle is appropriate.

—
Reply to this email directly or view it on GitHub
#5641 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

When I looked at this issue in the past, I considered that we should if possible use list when the choice is not between Positive and Negative action, this because of the use of Green and Red colours when only 2 choices.
If we had a css that would use other colours, That would solve that issue.

That would be OK (I guess) if we consistently used that but we dont

On 8 January 2015 at 09:35, infograf768 notifications@github.com wrote:

When I looked at this issue in the past, I considered that we should if
possible use list when the choice is not between Positive and Negative
action, this because of the use of Green and Red colours when only 2
choices.
If we had a css that would use other colours, That would solve that issue.

—
Reply to this email directly or view it on GitHub
#5641 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Please see #5641