Moving to RTC based on review and the comments here: http://issues.joomla.org/tracker/joomla-cms/5639

As this PR just set the default values that is used by the code. Good find @brianteeman

I suggest we should do the opposite and rather change the language string
PLG_SYSTEM_LANGUAGEFILTER_FIELD_COOKIE_DESC to inform that session is default as this was indeed forgotten when we added the Session value.

So now I am confused. The string says and the xml say one thing is the
default but you are saying its the opposite.

On 8 January 2015 at 09:25, infograf768 notifications@github.com wrote:

I suggest we should do the opposite and rather change the language string
PLG_SYSTEM_LANGUAGEFILTER_FIELD_COOKIE_DESC to inform that session is
default as this was indeed forgotten when we added the Session value.

—
Reply to this email directly or view it on GitHub
#5640 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

The default value was changed when we committed
12aaec7

I.e. the default was from there on "Session" and not "Year"

But the string was not changed correctly.
It should be;
PLG_SYSTEM_LANGUAGEFILTER_FIELD_COOKIE_DESC="Language cookies can be set to expire at the end of the session or after a year. Default is session."

OK I will update this PR to change the language string NOT the xml - thanks

On 8 January 2015 at 10:09, infograf768 notifications@github.com wrote:

The default value was changed when we committed
12aaec7
12aaec7

I.e. the default was from there on "Session" and not "Year"

But the string was not changed correctly.
It should be;
PLG_SYSTEM_LANGUAGEFILTER_FIELD_COOKIE_DESC="Language cookies can be set
to expire at the end of the session or after a year. Default is session."

—
Reply to this email directly or view it on GitHub
#5640 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

I have updated the PR to change the language string as requested and not the xml

Thanks. Merged.