? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
3 Jan 2015

This affects /administrator/index.php?option=com_users&view=users
where a modal script is included but never used!

Testing:
Go to http://localhost/administrator/index.php?option=com_users&view=users
and observe (e.g.: firebug) that modal and mootools + mootools-more is present

Apply this patch and revisit the same page
modal, mootools + mootools-more should be absent and everything should work as usual!

This is a no brainer

avatar dgt41 dgt41 - open - 3 Jan 2015
avatar jissues-bot jissues-bot - change - 3 Jan 2015
Labels Added: ?
avatar dgt41 dgt41 - change - 3 Jan 2015
Title
Remove redundant calls for mootools
Remove redundant call for modal
avatar zero-24 zero-24 - change - 3 Jan 2015
Category JavaScript
avatar jissues-bot jissues-bot - change - 3 Jan 2015
Title
Remove redundant call for modal
Remove redundant calls for mootools
avatar dgt41
dgt41 - comment - 4 Jan 2015

jissuses-bot seems to have a strong character and doesn’t let me correct the title and the first comment!

This affects /administrator/index.php?option=com_users&view=users
where a modal script is included but never used!

Testing:
Go to http://localhost/administrator/index.php?option=com_users&view=users
and observe (e.g.: firebug) that modal and mootools + mootools-more is present

Apply this patch and revisit the same page
modal, mootools + mootools-more should be absent and everything should work as usual!

avatar brianteeman
brianteeman - comment - 4 Jan 2015

jissuses-bot seems to have a strong character and doesn’t let me correct
the title and the first comment!

(If the problem is that you arent seeing your edits then just be patient.
It only syncs every 15 mins IIRC)

On 4 January 2015 at 10:24, Dimitris Grammatiko notifications@github.com
wrote:

jissuses-bot seems to have a strong character and doesn’t let me correct
the title and the first comment!

This affects /administrator/index.php?option=com_users&view=users
where a modal script is included but never used!

Testing:
Go to http://localhost/administrator/index.php?option=com_users&view=users
and observe (e.g.: firebug) that modal and mootools + mootools-more is
present

Apply this patch and revisit the same page
modal, mootools + mootools-more should be absent and everything should
work as usual!


Reply to this email directly or view it on GitHub
#5609 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar zero-24
zero-24 - comment - 4 Jan 2015

(If the problem is that you arent seeing your edits then just be patient.
It only syncs every 15 mins IIRC)

@brianteeman
The last i know is every 30 mins see: joomla/jissues#483 (comment) :smiley:

avatar dgt41
dgt41 - comment - 4 Jan 2015

@brianteeman @zero-24 @mbabker I think there is a design limitation on issue tracker. Try creating a new PR in github with some stupid title and some description. Wait till it gets synced from bot. Try to rename the PR’s title and description… It won’t happen (when cron runs again will restore the initial tile and description)

This is what i get:
screen shot 2015-01-04 at 1 38 23

avatar zero-24
zero-24 - comment - 4 Jan 2015

@dgt41 what is if you change the title on/with jissues? http://issues.joomla.org/tracker/joomla-cms/5609

avatar dgt41 dgt41 - change - 4 Jan 2015
Title
Remove redundant calls for mootools
Remove redundant call for modal
avatar dgt41 dgt41 - change - 4 Jan 2015
The description was changed
Title
Remove redundant calls for mootools
Remove redundant call for modal
avatar brianteeman
brianteeman - comment - 4 Jan 2015

Please report and discuss this on the tracker for JIssues

On 4 January 2015 at 11:49, zero-24 notifications@github.com wrote:

@dgt41 https://github.com/dgt41 what is if you change the title on/with
jissues? http://issues.joomla.org/tracker/joomla-cms/5609


Reply to this email directly or view it on GitHub
#5609 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 4 Jan 2015

@zero-24 Changes made in issue tracker do the trick

avatar brianteeman
brianteeman - comment - 5 Jan 2015

Closing as the PR is created under a mistaken premise as George states


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5609.

avatar brianteeman brianteeman - change - 5 Jan 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-01-05 10:31:56
Closed_By brianteeman
avatar brianteeman brianteeman - close - 5 Jan 2015
avatar brianteeman brianteeman - close - 5 Jan 2015
avatar dgt41
dgt41 - comment - 5 Jan 2015

Sorry guys, next time I will be more carefull on the code I suggest!

avatar dgt41 dgt41 - head_ref_deleted - 20 Jan 2015

Add a Comment

Login with GitHub to post a comment