User tests: Successful: Unsuccessful:
This affects /administrator/index.php?option=com_users&view=users
where a modal script is included but never used!
Testing:
Go to http://localhost/administrator/index.php?option=com_users&view=users
and observe (e.g.: firebug) that modal and mootools + mootools-more is present
Apply this patch and revisit the same page
modal, mootools + mootools-more should be absent and everything should work as usual!
This is a no brainer
Labels |
Added:
?
|
Title |
|
Category | ⇒ | JavaScript |
Title |
|
jissuses-bot seems to have a strong character and doesn’t let me correct
the title and the first comment!
(If the problem is that you arent seeing your edits then just be patient.
It only syncs every 15 mins IIRC)
On 4 January 2015 at 10:24, Dimitris Grammatiko notifications@github.com
wrote:
jissuses-bot seems to have a strong character and doesn’t let me correct
the title and the first comment!This affects /administrator/index.php?option=com_users&view=users
where a modal script is included but never used!Testing:
Go to http://localhost/administrator/index.php?option=com_users&view=users
and observe (e.g.: firebug) that modal and mootools + mootools-more is
presentApply this patch and revisit the same page
modal, mootools + mootools-more should be absent and everything should
work as usual!—
Reply to this email directly or view it on GitHub
#5609 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
(If the problem is that you arent seeing your edits then just be patient.
It only syncs every 15 mins IIRC)
@brianteeman
The last i know is every 30 mins see: joomla/jissues#483 (comment)
@brianteeman @zero-24 @mbabker I think there is a design limitation on issue tracker. Try creating a new PR in github with some stupid title and some description. Wait till it gets synced from bot. Try to rename the PR’s title and description… It won’t happen (when cron runs again will restore the initial tile and description)
@dgt41 what is if you change the title on/with jissues? http://issues.joomla.org/tracker/joomla-cms/5609
Title |
|
Title |
|
Please report and discuss this on the tracker for JIssues
On 4 January 2015 at 11:49, zero-24 notifications@github.com wrote:
@dgt41 https://github.com/dgt41 what is if you change the title on/with
jissues? http://issues.joomla.org/tracker/joomla-cms/5609—
Reply to this email directly or view it on GitHub
#5609 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
@test unsuccessful. If you have a note assigned to a user then it will display "Display 1 note". Clicking on this opens a modal (see class at https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_users/helpers/html/users.php#L94 which is called on line https://github.com/dgt41/joomla-cms/blob/_redundant_js/administrator/components/com_users/views/users/tmpl/default.php#L126)
See this tracker for full details http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=31678&start=0
Closing as the PR is created under a mistaken premise as George states
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-05 10:31:56 |
Closed_By | ⇒ | brianteeman |
Sorry guys, next time I will be more carefull on the code I suggest!
jissuses-bot seems to have a strong character and doesn’t let me correct the title and the first comment!
This affects /administrator/index.php?option=com_users&view=users
where a modal script is included but never used!
Testing:
Go to http://localhost/administrator/index.php?option=com_users&view=users
and observe (e.g.: firebug) that modal and mootools + mootools-more is present
Apply this patch and revisit the same page
modal, mootools + mootools-more should be absent and everything should work as usual!