[#5610] - Redo for: made output of space conditional -> cause problems with gui tests
- Closed
- 6 Jan 2015
- Medium
- Build: staging
- # 5610
- Diff
- zero-24:patch-8
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
I changed the template how Joomla renders the fields in an backend edit view. In detail, the template generates a div-element with the css class "control-group ". Always with an additional space at the end of the css class "control-group".
My fix sets the css class to "control-group" if there is no additional css class. (without the additional space) else the space is added.
Use the 'renderFieldset' function in the 'JForm' class, Joomla uses the layout in renderfield.php to create the form fields.
The output of this method is not the same as in the Joomla core extensions. This fix makes the output consistent with the Joomla core extension template.
How to test
- Access a article and e.g. use Firebug to see the HTML Code for a renderd field.
- use the
view-sourceoption of your browser to see the renderd field - apply this patch e.g. vie com_patchtester
- see the same field again
New PR for: #5200 against staging. Code and credit by @Wolf-Rost
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Layout UI/UX |
losedk
- | Status | Pending | ⇒ | Ready to Commit |
Thanks @infograf768, @losedk and @wilsonge moving to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5610.
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-01-06 08:05:08 |
@test
Looks fine here.