[#5336] - Smart Search - Corrects the ordering of loaded JS files ...
- Closed
- 8 Dec 2014
- Medium
- Build: staging
- # 5336
- Diff
- Kubik-Rubik:com_finder-ordering-js-files
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
... and removes the explicit loading of Mootools (loaded automatically by progressbar.js call)
Jquery has to be loaded before indexer.js and Mootools doesn't have to be loaded explicitly because it is loaded automatically. (We should remove the dependency of Mootools in progressbar.js in another PR)
How to test?
Apply this PR and run the indexer in the finder component (Smart Search). Everything should run properly and the items indexed properly.
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Components JavaScript |
@dgt41 Let us first optimize the loading ordering and in a second step move them in the template files because it has to be done in many places (components). Agree?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5336.
@Kubik-Rubik but this way is kinda double work, I guess? Anyways if this is the way you think is gonna be easier to test/merge no real objection here. Test results coming soon...
Guys, this MUST be merged: without this com_finder indexing is broken with the current staging code...
@smanzi @Kubik-Rubik The same goes for #5099
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- | Labels |
Added:
?
|
||
zero-24
- 
Bakual
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-08 18:37:05 |
| Labels |
Removed:
?
|
||
@Kubik-Rubik May I suggest to move all the calls to tmpl/default.php. I think this is the proper place to call any needed scripts
My 2c