[#5335] - Fixes image logo in Isis template - #5270
- Closed
- 15 Dec 2014
- Medium
- Build: 3.4-dev
- # 5335
- Diff
- victorparanhos:iss5270
- Error The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
Fixes image logo in isis as reported on ticket #5270.
Votes
jissues-bot
- | Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-07 17:39:40 |
| Status | Closed | ⇒ | New |
zero-24
- | Category | ⇒ | Templates (admin) |
| Status | New | ⇒ | Pending |
Maybe it would be preferable to simply do something like this?
header .container-logo {overflow: hidden;}
That will prevent the image borking the navbar, it's simple and IE proof.
Thanks, @nternetinspired and @infograf768.
The generatecss is removing some rtl.css lines that I haven't changed. What I am doing wrong?
.container-logo {overflow: hidden;} does not work here (Firefox Macintosh)
and going down
@victorparanhos
You are not using the last version of staging.
I get a good result by using
.header .container-logo img {
height: 32px;
}
This should be IE8 compatible (to test) and keeps proportions of the image.
Same image as above gives:
Original image is 732 x 1200
@victorparanhos
Are you going to create a new PR vs staging to get this in?
@infograf768 Yes, I'll create a new PR as soon as possible using staging... Thank you and I'm sorry for anything I did wrong.
z-index will solve the issue but logo container cant be perfect for every logo!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5335.
OK administrator/templates/isis/css/template.css line:7200
change .subhead-collapse.collapse{height:auto;overflow:hidden;}
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5335.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 2014-12-07 17:39:40 | ⇒ | 2014-12-15 14:31:41 |
missing in rtl.css
looks like this was not generated with generate.css
also, as I said in the former PR, IE8 may not work with this.