User tests: Successful: Unsuccessful:
To test check Install Languages Manager continues to work as expected
Labels |
Added:
?
|
Category | ⇒ | Installation Updating |
@wilsonge P.P.S. I've made a comment on a line in your PR on missing qouting of table name in one case. Please check. Thanks a lot.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.
Title |
|
Good spot with me missing that one place! Yeah it's very inconsistently implemented across Joomla so I just try and make sure all new PR's have it added in and slowly but surely things will improve :)
@wilsonge A general question: When I have tested a PR of someone else with success, do I make a comment with "at-test" (do not want to use at symbol here not to cause a message)? Or do I use the test result selection at the right hand side of the issue tracker ("test-item")? Or both?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.
The at test thing is not really needed anymore. We moved over to a fully github based system about 6 months ago and the old way of marking tests used to use the at-test thing. You'll just see loads of people (including me sometimes) doing it out of habit :D
But yeah to answer your question put it on the issues tracker and just a quick comment on the tracker itself just to prove its not someone who's gone through the tracker marking successful tests to cause havoc
@wilsonge Well, if I should add a comment here anyway, then the at-test thing can help quickly find the comment, so I think I'll continue use it then, too ;-)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.
@test Tested with success in the same way as the original PR #5327 , for which test is described with tracker issue #5320 .
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.
Status | Pending | ⇒ | Ready to Commit |
moving to RTC as we have 2 successful tests. Thanks @wilsonge @richard67 and @waader
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.
Labels |
Added:
?
|
OK here. Merging. thanks.
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-06 06:17:18 |
Labels |
Removed:
?
|
@wilsonge Thanks for fixing it. I will test your PR soon.
I based on what I found in existing code when I added new queries in langauges.php, but I asked myself in the same moment when I did it, if not everything (i.e. also column names and table named) should be quoted.
But I was too shy not to trust what I had found. Next time I will know and be more courageous.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.