? Success

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
5 Dec 2014

To test check Install Languages Manager continues to work as expected

avatar wilsonge wilsonge - open - 5 Dec 2014
avatar jissues-bot jissues-bot - change - 5 Dec 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 5 Dec 2014
Category Installation Updating
avatar richard67
richard67 - comment - 5 Dec 2014

@wilsonge Thanks for fixing it. I will test your PR soon.

I based on what I found in existing code when I added new queries in langauges.php, but I asked myself in the same moment when I did it, if not everything (i.e. also column names and table named) should be quoted.

But I was too shy not to trust what I had found. Next time I will know and be more courageous.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.

avatar richard67
richard67 - comment - 5 Dec 2014

@wilsonge P.S. You have a typo in the title of this PR: 5237 should be 5327 ;-)

avatar richard67
richard67 - comment - 5 Dec 2014

@wilsonge P.P.S. I've made a comment on a line in your PR on missing qouting of table name in one case. Please check. Thanks a lot.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.

avatar wilsonge wilsonge - change - 5 Dec 2014
Title
Add quoteName's into #5237
Add quoteName's into #5327
avatar wilsonge
wilsonge - comment - 5 Dec 2014

Good spot with me missing that one place! Yeah it's very inconsistently implemented across Joomla so I just try and make sure all new PR's have it added in and slowly but surely things will improve :)

avatar richard67
richard67 - comment - 5 Dec 2014

@wilsonge A general question: When I have tested a PR of someone else with success, do I make a comment with "at-test" (do not want to use at symbol here not to cause a message)? Or do I use the test result selection at the right hand side of the issue tracker ("test-item")? Or both?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.

avatar richard67 richard67 - test_item - 5 Dec 2014 - Tested successfully
avatar wilsonge
wilsonge - comment - 5 Dec 2014

The at test thing is not really needed anymore. We moved over to a fully github based system about 6 months ago and the old way of marking tests used to use the at-test thing. You'll just see loads of people (including me sometimes) doing it out of habit :D

But yeah to answer your question put it on the issues tracker and just a quick comment on the tracker itself just to prove its not someone who's gone through the tracker marking successful tests to cause havoc

avatar richard67
richard67 - comment - 5 Dec 2014

@wilsonge Well, if I should add a comment here anyway, then the at-test thing can help quickly find the comment, so I think I'll continue use it then, too ;-)

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.

avatar richard67
richard67 - comment - 5 Dec 2014

@test Tested with success in the same way as the original PR #5327 , for which test is described with tracker issue #5320 .

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.

avatar waader
waader - comment - 5 Dec 2014

@test works!

avatar waader waader - test_item - 5 Dec 2014 - Tested successfully
avatar zero-24 zero-24 - change - 5 Dec 2014
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 5 Dec 2014

moving to RTC as we have 2 successful tests. Thanks @wilsonge @richard67 and @waader

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5329.

avatar brianteeman brianteeman - change - 5 Dec 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 6 Dec 2014

OK here. Merging. thanks.

avatar zero-24 zero-24 - close - 6 Dec 2014
avatar infograf768 infograf768 - close - 6 Dec 2014
avatar infograf768 infograf768 - change - 6 Dec 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-12-06 06:17:18
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment