Feeling Lucky
?
[#5330] - Fixes image logo in isis - #5270
- Closed
- 6 Dec 2014
- Medium
- Build: 3.4-dev
- # 5330
- Diff
- victorparanhos:iss5270
- Success The Travis CI build passed Details
Related to
# 5270
User tests: Successful: Unsuccessful:
Fixes Fixes image logo in isis as reported on ticket #5270.
This is my first pull-request to a project. If I need to do anything different, tell me.
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Templates (admin) |
| Rel_Number | ⇒ | 5270 | |
| Relation Type | ⇒ | Related to |
brianteeman
- comment
- 6 Dec 2014
Is this what you intended to do - squash the image to fit the existing space?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5330.
infograf768
- comment
- 6 Dec 2014
PR wrong as trying to change .view-login in rtl.css which is already changed in core/staging.
new css should rather be something like
.header .container-logo img {
max-height: 32px;
width: auto;
}
to keep the right proportions.
Could need something else for IE8 though.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-06 15:56:19 |
micker
- comment
- 8 Dec 2014
thanks !
Thanks for your contribution
As this is a change in the css you need to make it in the less file and
then sue the generatecss script to create the css
On 5 December 2014 at 19:33, Victor Paranhos notifications@github.com
wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/