User tests: Successful: Unsuccessful:
#5291 was inadvertently reverted by @richard67 - this re-instate its code...
No need for testing, I think...
Labels |
Added:
?
|
@test Tested with success as done with original PR #5291 .
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.
@smanzi Well, testing was not necessary but maybe useful for statistics ;-) Question: Shall I close by PR #5291 now as you opened this one? If yes, I could close it and then delete my repository (because no other things in progrss there) and create one again (new clean start), and in future I will always use own branches and not the staging for doing things on my repo.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.
@smanzi Ahh, PR #5291 was already merged, I forgot .. so forget my question about closing it. But can you advice: Should I delete my repo now and make a new one for a clean start?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.
If you have no other PR pending, yes, you can delete your repo and re-fork, but actually there is no need for that (even if your staging branch is dirty). Let me explain you what to to:
git checkout staging
git remote update
git reset --hard upstream/staging
git push origin +staging
joomla/joomla-cms/staging
too. In case you need to do a merge and not a "reset --hard" (in the branch you were editing, I mean...)for the above list of command I've actually added an alias in my local .gitconfig file:
[alias]
resetstaging = !git checkout staging && git remote update && git reset --hard upstream/staging && git push origin +staging
then in GitShell I can simply use git resetstaging
Hope this can be helpful...
@smanzi Very helpful. Thanks a lot.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.
Status | Pending | ⇒ | Ready to Commit |
moving to RTC since the same code was tested here by three @brianteeman, @dgt41, @smanzi and here by @richard67 Thanks to all!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-06 06:01:05 |
Labels |
Removed:
?
|
@smanzi thanks for realizing and fixing it (blush).
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.