? Success

User tests: Successful: Unsuccessful:

avatar smanzi
smanzi
5 Dec 2014

#5291 was inadvertently reverted by @richard67 - this re-instate its code...

No need for testing, I think...

avatar smanzi smanzi - open - 5 Dec 2014
avatar jissues-bot jissues-bot - change - 5 Dec 2014
Labels Added: ?
avatar richard67
richard67 - comment - 5 Dec 2014

@smanzi thanks for realizing and fixing it (blush).

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.

avatar richard67 richard67 - test_item - 5 Dec 2014 - Tested successfully
avatar richard67
richard67 - comment - 5 Dec 2014

@test Tested with success as done with original PR #5291 .

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.

avatar richard67
richard67 - comment - 5 Dec 2014

@smanzi Well, testing was not necessary but maybe useful for statistics ;-) Question: Shall I close by PR #5291 now as you opened this one? If yes, I could close it and then delete my repository (because no other things in progrss there) and create one again (new clean start), and in future I will always use own branches and not the staging for doing things on my repo.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.

avatar richard67
richard67 - comment - 5 Dec 2014

@smanzi Ahh, PR #5291 was already merged, I forgot .. so forget my question about closing it. But can you advice: Should I delete my repo now and make a new one for a clean start?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.

avatar smanzi
smanzi - comment - 5 Dec 2014

@richard67

If you have no other PR pending, yes, you can delete your repo and re-fork, but actually there is no need for that (even if your staging branch is dirty). Let me explain you what to to:

  • if you haven't already done that, install "GitHub for Windows"
  • once installed and you have cloned your remote repo on your PC, select it (in GitHub for Window) and select branch 'staging'
  • in the left side right click on the repo name and select "Open in GitShell"
  • in GitShell issue the following commands:
git checkout staging
git remote update
git reset --hard upstream/staging
git push origin +staging
  • et voilĂ ! You have a clean staging (both local and remote) aligned with the current state: any modification you did to your staging copy are reset and lost
  • from now on remember to create a new branch for each PR you want to submit
  • no need to sync then your branch with upstream/staging, unless some of the files you were editing have been modified in joomla/joomla-cms/staging too. In case you need to do a merge and not a "reset --hard" (in the branch you were editing, I mean...)

for the above list of command I've actually added an alias in my local .gitconfig file:

[alias]
    resetstaging = !git checkout staging && git remote update && git reset --hard upstream/staging && git push origin +staging

then in GitShell I can simply use git resetstaging

Hope this can be helpful...

avatar richard67
richard67 - comment - 5 Dec 2014

@smanzi Very helpful. Thanks a lot.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.

avatar zero-24 zero-24 - change - 5 Dec 2014
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 5 Dec 2014

moving to RTC since the same code was tested here by three @brianteeman, @dgt41, @smanzi and here by @richard67 Thanks to all!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5328.

avatar brianteeman brianteeman - change - 5 Dec 2014
Labels Added: ?
avatar zero-24 zero-24 - close - 6 Dec 2014
avatar infograf768 infograf768 - close - 6 Dec 2014
avatar infograf768 infograf768 - change - 6 Dec 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-12-06 06:01:05
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment