Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5305] - Fix PHP warning for trying to loop over false variable

? Success

User tests: Successful: Unsuccessful:

avatar chivitli
chivitli
3 Dec 2014

Search bots are filling my error log because there was no proper check of the variable before looping over it. Note: I just added the same check which already exists in view.html.php and which was missing here.

avatar chivitli chivitli - open - 3 Dec 2014
avatar jissues-bot jissues-bot - change - 3 Dec 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 6 Dec 2014
Category ⇒ Tags
avatar Hackwar
Hackwar - comment - 8 Dec 2014

I would have used is_array(), but your solution is okay, too. @test success. (going to mark that accordingly on JIssues now.)

avatar Hackwar Hackwar - test_item - 8 Dec 2014 - Tested successfully
avatar waader
waader - comment - 11 Dec 2014

@test works for me!

avatar waader waader - test_item - 11 Dec 2014 - Tested successfully
avatar zero-24 zero-24 - change - 11 Dec 2014
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 11 Dec 2014

Moving to RTC since we have 2 successful tests. Thanks to all.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5305.

avatar brianteeman brianteeman - change - 11 Dec 2014
Labels Added: ?
avatar zero-24 zero-24 - close - 13 Dec 2014
avatar wilsonge
wilsonge - comment - 13 Dec 2014

Fixed in 3573a9f - thanks!

avatar wilsonge wilsonge - close - 13 Dec 2014
avatar wilsonge wilsonge - change - 13 Dec 2014
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-12-13 19:18:57
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment