@chivitli The plugin should not be called at all if the article is not available! Can you please explain how to reproduce the described problem?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5306.

It's about accessing a page of an available article which has pages inside. Create an article, accessible via example.com/my-article, and make sure that it has at least two pages, so that the page example.com/my-article?start=1 also exists. If you try to access example.com/my-article?start=2 etc you'll see a notice

I would say that the plugin needs to throw a 404 if that page is non-existent. Otherwise the user/search engine simply sees an article with no content... So if the page is not defined, please throw a 404.

I can reproduce this btw. So it's definitely an issue we need to address

As I wrote in december: It needs to throw a 404. The URL is invalid and thus should throw a 404. Otherwise you have a "duplicate content" issue with pages n to n+infinity.

The notice disappeared (Notice: Undefined offset: 4 in C:\xampp\htdocs\plugins\content\pagebreak\pagebreak.php on line 180)

@test successful
Tested a page with pagebreak and ?showall=&start=200
works

however, throwing a 404 sound logical, too.

Moving to Needs Review so a Maintainer can take a decision here Thanks

Agree with @Hackwar , if a page doesn't exist we should throw a 404. This is how it works with other content pages as well. Load any article in the front-end with a non-existent ID and you get a 404 as expected.

@chivitli Can you please update your PR to throw a 404 in case the page doesn't exist?

Hello @chivitli

Thank you for your contribution.

The last comment here was on September 6th. Can you please follow-up?
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!

This PR has received new commits.

CC: @FloryGlory, @seagul30

This PR has received new commits.

CC: @FloryGlory, @seagul30

This PR has received new commits.

CC: @FloryGlory, @seagul30

@roland-d

Sorry for the delay. I updated the pull request to throw 404 and added a new language constant. Please test again

Thanks!

@chivitli There is a codestyle issue:

FILE: .../travis/build/joomla/joomla-cms/plugins/content/pagebreak/pagebreak.php

FOUND 1 ERROR(S) AFFECTING 1 LINE(S)

129 | ERROR | Whitespace found at end of line

Can you fix that as well? Thanks.

This PR has received new commits.

CC: @FloryGlory, @seagul30

@roland-d

Sure, fixed!

@FloryGlory @seagul30 Can you guys please test one more time? Thank you.

This PR has received new commits.

CC: @FloryGlory, @seagul30

I changed JError to Exception, let's help win that lottery ticket :-)

I have tested this item successfully on fa068d4

Patch works fine.

Although the pagebreak ini file is loaded in frontend, I suggest to change the new string to a generic one in en-GB.ini as it could be used by anyone to throw a "Page not found".

It would be
JERROR_PAGE_NOT_FOUND="Page not found" to be added line 126

@infograf768

Suggestion accepted, thanks.

This PR has received new commits.

CC: @andrepereiradasilva, @FloryGlory, @seagul30

This PR has received new commits.

CC: @andrepereiradasilva, @FloryGlory, @seagul30

This PR has received new commits.

CC: @andrepereiradasilva, @FloryGlory, @seagul30

I have tested this item successfully on b5e7bbe

I have tested this item successfully on b5e7bbe

RTC - thanks