?
avatar dgt41
dgt41
3 Dec 2014

This affects 3.3.6 and 3.4

Problem 1

Go to administrator-> Menus -> Select a menu
Select a menu item e.g. Home and go to edit screen
Go to Module Assignment (last tab) and select click on any of the available modules
Don’t press cancel inside the modal but close the modal either with esc key or clicking on the x in the top right corner.
Go to Extensions -> Module Manager Observe that the module is locked and needs a check out!

This is wrong!
This was found by @smanzi and there is a solution in #4661 (but that few lines can easily converted to cover the current modal)

Problem 2.

Follow the steps above but this time before you click on any module please take note of the position
Also don’t exit the modal without any modification, instead choose another module position.
Save and exit to close the modal.
The module position in the parent window doesn’t change as it should be!

This video demonstrates both problems

avatar dgt41 dgt41 - open - 3 Dec 2014
avatar jissues-bot jissues-bot - change - 3 Dec 2014
Labels Added: ?
avatar vdespa vdespa - change - 3 Dec 2014
Category Administration
avatar smanzi
smanzi - comment - 3 Dec 2014

@dgt41 I'm afraid there are also a "Problem 3" and a "Problem 4"

Problem 3.

Three pictures are worth a hundred words...
1
2
3

A similar issues is present also for "Articles". Not sure about other batch operations

Problem 4.

I'm unable to reorder modules positions by dragging...

Problem 5.

Should we split this in different issues or we keep on going with this? :smile:

avatar dgt41
dgt41 - comment - 3 Dec 2014

About problem 4: was that ever possible?

avatar smanzi
smanzi - comment - 3 Dec 2014

I'm pretty sure yes... let me check...

avatar smanzi
smanzi - comment - 3 Dec 2014

works like a charm with 3.3.6...

avatar dgt41
dgt41 - comment - 3 Dec 2014

care to share a pic I don’t really get "reorder modules positions by dragging" in which view?

avatar smanzi
smanzi - comment - 3 Dec 2014

skype + teamviewer...

avatar brianteeman
brianteeman - comment - 3 Dec 2014

Is this all on your uniform server install? If it is then I am not
personally going to take any notice of any reports found on that as it is
clearly not performing as expected

On 3 December 2014 at 21:08, Sergio Manzi (smz) notifications@github.com
wrote:

@dgt41 https://github.com/dgt41 I'm afraid there are also a "Problem 3"
and a "Problem 4"
Problem 3.

Three pictures are worth a hundred words...
[image: 1]
https://cloud.githubusercontent.com/assets/4165717/5288772/4bbef1d8-7b38-11e4-85ad-827d30b63b06.PNG
[image: 2]
https://cloud.githubusercontent.com/assets/4165717/5288774/5131f93a-7b38-11e4-9fc9-d8bd8f4a8b64.PNG
[image: 3]
https://cloud.githubusercontent.com/assets/4165717/5288776/543be302-7b38-11e4-89b8-d81339f3fd8d.PNG

A similar issues is present also for "Articles". Not sure about other
batch operations
Problem 4.

I'm unable to reorder modules positions by dragging...
Problem 5.

Should we split this in different issues or we keep on going with this? [image:
:smile:]


Reply to this email directly or view it on GitHub
#5304 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 3 Dec 2014

@brianteeman Actually except the modal thing everything else is there..

avatar dgt41
dgt41 - comment - 3 Dec 2014

Also for no 4 he is referring to com_modules, but for that a PR is on it’s way...

avatar smanzi
smanzi - comment - 3 Dec 2014

@brianteeman review the code and you'll believe... see PR #5309

avatar smanzi
smanzi - comment - 3 Dec 2014

@brianteeman ... and in any case I'm now double-checking on 2 different VPS, one in Amsterdam and one even closer to you, in London :gb:

avatar infograf768
infograf768 - comment - 4 Dec 2014

Patch for 4 is merged.

avatar infograf768
infograf768 - comment - 4 Dec 2014

Problem 3 is NOT a problem: it is clearly indicated in the modal.
"When copying and not changing position, it is nevertheless necessary to select 'Keep Original Position' in the dropdown"

avatar infograf768
infograf768 - comment - 4 Dec 2014

Concerning problem 2:
I confirm the issue. I guess we have to reload the form in a way or another.

avatar dgt41
dgt41 - comment - 4 Dec 2014

@infograf768 Wouldn’t be nicer if Module Assignment tab was just what the title says?
e.g.:
screen shot 2014-12-04 at 11 41 39

avatar infograf768
infograf768 - comment - 4 Dec 2014

Do you mean "without giving the ability to edit the module?"

avatar dgt41
dgt41 - comment - 4 Dec 2014

We can still have a link to open the module edit page, but if it would be in a modal we are back to the same problem

avatar infograf768
infograf768 - comment - 4 Dec 2014

It is easy to set the title to readonly when the modal is used, but not the location as it is a specific field Type

avatar dgt41
dgt41 - comment - 4 Dec 2014

you can pass the value from the modal, but no # id to target it… Let me see if I can come up with some fix in the current state

avatar smanzi
smanzi - comment - 4 Dec 2014

@infograf768 Regarding problem (or not problem) 3, you're absolutely right that it is documented that "When copying and not changing position, it is nevertheless necessary to select 'Keep Original Position' in the dropdown", but what is not documented is the side effect of not abiding to that rule: what I (as an end-user) would expect is some kind of warning or error message. Transforming the "copy" operation to a "move" operation is IMHO quite unexpected and a bad thing to do...

I've chatted with @dgt41 about that and he is saying that it is a not so easy thing to fix, but that when he will have some time he will take a look and see if something can be done.

Off the top of my head and without having thought to that much, I'm wondering if it wouldn't it be better to set the "Position field" to a default of "Keep original position"...

avatar dgt41
dgt41 - comment - 4 Dec 2014

@infograf768 we might have a possible solution for problem no 2 at #5325

avatar dgt41 dgt41 - close - 14 Dec 2014
avatar dgt41 dgt41 - change - 14 Dec 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-12-14 15:39:24

Add a Comment

Login with GitHub to post a comment