? ? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
20 Nov 2014

Like #2253 but for staging instead of master.

Basically, since JLog now supports category exclusion instead of just inclusion, the logging feature in this plugin should also give that option. Exclusion is much more useful than inclusion in this case anyway because you probably want to see most logs but you will never want to see databasequery logs and you might get tired of looking at deprecated logs.

avatar okonomiyaki3000 okonomiyaki3000 - open - 20 Nov 2014
avatar jissues-bot jissues-bot - change - 20 Nov 2014
Labels Added: ?
avatar okonomiyaki3000
okonomiyaki3000 - comment - 20 Nov 2014

Setup

  • Turn on debug mode.
  • In the debug plugin settings, set logging to log all all priorities.
  • Don't set a category because categories are like a box of chocolates, you never know what you're gonna get (but you do know which ones you don't want).

Before

You will see logs for every category. Mostly databasequery and deprecated

After

You can set categories to exclude and list the ones you don't want to see. This definitely includes databasequery because the debug plugin is listing them all anyway and it might also include deprecated unless you're on a mission to fix all that deprecated code. What's left will be a short, sweet list of logs that you might actually care about.

avatar brianteeman brianteeman - change - 21 Nov 2014
Category Plugins
avatar waader
waader - comment - 22 Nov 2014

@test success

avatar okonomiyaki3000
okonomiyaki3000 - comment - 22 Nov 2014

Thanks!

avatar zero-24
zero-24 - comment - 29 Nov 2014

@okonomiyaki3000 i think we should use class="btn-group btn-group-yesno" for the Include/Exclude Button.

Can we move the logging options to the logging file set?
https://github.com/joomla/joomla-cms/blob/staging/plugins/system/debug/debug.xml#L81-108

https://github.com/joomla/joomla-cms/blob/staging/plugins/system/debug/debug.xml#L168

Or should we do this with in a different PR?

@okonomiyaki3000

if i add 'jcontroller' or 'controller' i still get a 'jcontroller.log.php'

Have i something missconfigured / missunderstanded?
debug_options

avatar okonomiyaki3000
okonomiyaki3000 - comment - 29 Nov 2014

Good point about btn-group.

If you want it in the logging field set, that's a different PR but not one that I'm going to make.

Yes, you have misunderstood what this is about. This has nothing to do with witing logs to files. This about displaying logs in the debug "console" or whatever it's called.

avatar zero-24
zero-24 - comment - 29 Nov 2014

Yes, you have misunderstood what this is about. This has nothing to do with witing logs to files. This about displaying logs in the debug "console" or whatever it's called.

Ok :+1: Now @test success.

Please add the class="btn-group btn-group-yesno" and this is good to go i think.

avatar zero-24 zero-24 - test_item - 29 Nov 2014 - Tested successfully
avatar zero-24 zero-24 - alter_testresult - 29 Nov 2014 - waader: Tested successfully
avatar brianteeman
brianteeman - comment - 30 Nov 2014

Multiple good tests setting to RTc - thanks

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5146.

avatar brianteeman brianteeman - change - 30 Nov 2014
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 30 Nov 2014
Labels Added: ?
avatar zero-24
zero-24 - comment - 1 Dec 2014

@comitter please let @okonomiyaki3000 time to add the class="btn-group btn-group-yesno" to the include / exclude button.

avatar roland-d
roland-d - comment - 17 Jan 2015

@okonomiyaki3000 @zero-24 Looking at this PR, it was correct to suggest to use the button group for the Include/Exclude. However I would like to see the Include/exclude swapped. It looks weird that Include is red and exclude is green.

avatar zero-24
zero-24 - comment - 17 Jan 2015

@roland-d is it better if we change it?

include -> green
exclude -> red

or other colors?

avatar roland-d
roland-d - comment - 17 Jan 2015

@zero-24 Indeed,
Include -> Green
Exclude -> Red

just like:
Yes -> Green
No -> Red

avatar zero-24
zero-24 - comment - 17 Jan 2015

@okonomiyaki3000 @roland-d

Can you have a look into this PR against this branche?: okonomiyaki3000#1 This should implement it.

but maybe a css fix is better?

avatar okonomiyaki3000
okonomiyaki3000 - comment - 19 Jan 2015

I'd like to hear some opinions on @zero-24 's PR. I don't have a problem with it but, it may cause a change to expected behavior in some cases (I can go into more detail if it's not obvious). I don't think it's a big deal so, unless there are any objections, I'll accept the PR.

avatar zero-24
zero-24 - comment - 19 Jan 2015

ok PR is closed based on comment by @roland-d to keep backwards compatible. but maybe we can add a comment that this should be changed with 4.0 @okonomiyaki3000 ?

avatar roland-d roland-d - change - 19 Jan 2015
Labels Added: ?
avatar roland-d roland-d - close - 19 Jan 2015
avatar roland-d roland-d - close - 19 Jan 2015
avatar zero-24 zero-24 - close - 19 Jan 2015
avatar roland-d roland-d - change - 19 Jan 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-01-19 21:31:37
avatar roland-d roland-d - change - 19 Jan 2015
Milestone Added:
avatar roland-d
roland-d - comment - 19 Jan 2015

@zero-24 I have added the label to reevaluate for v4.0. This way it won't be forgotten.

avatar zero-24
zero-24 - comment - 19 Jan 2015

Yes @roland-d this makes more sense. Thanks!

avatar okonomiyaki3000
okonomiyaki3000 - comment - 20 Jan 2015

But there's actually no BC issue unless we insist on swapping the colors which, to me, is totally arbitrary. It's not really that 'include' is affirmative while 'exclude' is negative. They're just two different modes. We don't even need colors at all, this option could just be a select.

avatar roland-d
roland-d - comment - 20 Jan 2015

Leaving it as-is isn't a problem either is it? I can't find it but there was something said about selects only for large listings, and button groups for 2 or 3 options.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 21 Jan 2015

It's not really a problem to leave it as-is but 'exclude' mode is far more useful than 'include' mode.

avatar roland-d
roland-d - comment - 21 Jan 2015

@okonomiyaki3000 I think you missed something. The exclude option has been merged into the core already.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 21 Jan 2015

Really? Great! What are we talking about then? Just changing the values so the colors will be different? Then I'm done because I do not care about that at all.

avatar okonomiyaki3000 okonomiyaki3000 - head_ref_deleted - 22 Jan 2015
avatar zero-24 zero-24 - change - 24 Aug 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 24 Aug 2015
Milestone Added:
avatar zero-24 zero-24 - change - 24 Aug 2015
Milestone Added:
avatar zero-24 zero-24 - change - 24 Aug 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment