? ? ? Failure
Referenced as Related to: # 1192 # 12288

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
20 Nov 2014

This is the same as #1192 but for staging instead of master.

avatar okonomiyaki3000 okonomiyaki3000 - open - 20 Nov 2014
avatar jissues-bot jissues-bot - change - 20 Nov 2014
Labels Added: ?
avatar Hackwar
Hackwar - comment - 20 Nov 2014

Can you fix the codestyle errors?

avatar zero-24 zero-24 - change - 11 Apr 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 29 Sep 2015
Labels Added: ?
avatar okonomiyaki3000
okonomiyaki3000 - comment - 29 Sep 2015

Fix some merge conflicts in this old thing. This is still really cool, btw.

avatar zero-24
zero-24 - comment - 29 Sep 2015

Hmm looks like a unit test fails here?

Can you have a look? https://travis-ci.org/joomla/joomla-cms/builds/82667974

avatar okonomiyaki3000
okonomiyaki3000 - comment - 5 Oct 2015

There was a bug in my code but I also found that the unit test was laughable. So it's a bit better now. However, it's using the assertTag test which may be a problem in the future. I think it's the best test for html because it doesn't fail on things like whitespace or other things that shouldn't matter in html but it seems to be removed in later version of phpunit so we may need to find a new way to test html output.

avatar mbabker
mbabker - comment - 5 Oct 2015

It's removed from PHPUnit 5. So either we need to eventually write something similar or pull in some third party library that has the ability to parse that stuff in a unit test run.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 5 Oct 2015

I'd rather just see all html removed from server-side code but that's kind of a pipe dream.

avatar dgt41
dgt41 - comment - 5 Oct 2015

@okonomiyaki3000 can you delete this file: libraries/joomla/form/options/index.html? Joomla dropped all the blank .html files long time ago

avatar okonomiyaki3000
okonomiyaki3000 - comment - 5 Oct 2015

Yeah, I seem to have some vague recollection of that.

avatar brianteeman brianteeman - change - 14 Mar 2016
Category Fields
avatar brianteeman brianteeman - change - 14 Mar 2016
Labels
avatar roland-d
roland-d - comment - 8 May 2016

@okonomiyaki3000 I know this is another old PR but I agree that this is still cool to implement. If you could update the PR to resolve the merge conflicts I will get some people to test this and we can implement it for 3.6. Thanks.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 9 May 2016

@roland-d Thanks, I was thinking of getting back to this one soon anyway. I'm glad to know there's interest in it. The usefulness of it might not be immediately obvious to everyone but I happen to think it's pretty great.

avatar roland-d roland-d - change - 29 May 2016
Milestone Added:
avatar roland-d
roland-d - comment - 29 May 2016

@okonomiyaki3000 I have set the milestone for now to 3.7.0 as we are too late for 3.6.0.

avatar brianteeman brianteeman - change - 12 Jul 2016
Category Fields Fields Unit Tests
avatar brianteeman brianteeman - change - 12 Jul 2016
Labels
avatar Edu20 Edu20 - test_item - 1 Aug 2016 - Tested unsuccessfully
avatar Edu20
Edu20 - comment - 1 Aug 2016

I have tested this item ? unsuccessfully on 742fa5e

I tested this Patch with the Patch Tester 2.0.1 and it throws an error: "The file marked for modification does not exist: layouts/joomla/fields/radio.php"

Tested @icampus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5147.

avatar wmchris wmchris - test_item - 1 Aug 2016 - Tested unsuccessfully
avatar wmchris
wmchris - comment - 1 Aug 2016

I have tested this item ? unsuccessfully on 742fa5e

Same error as Edu20 - file missing. Does this need another patch before?
@icampus


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5147.

avatar mbabker
mbabker - comment - 1 Aug 2016

Make sure you've actually got that file in your local install. Should be present as of 3.5.0.

avatar mbabker
mbabker - comment - 1 Aug 2016

Oh, nevermind, I see the issue now. This does need to be sync'd with staging it looks like; the file it's groaning about appears to have been renamed.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 1 Aug 2016

Sorry guys, this is really old and needs a lot of work. I'm glad it's getting some attention again because I still think it's a great idea but I need to find some time to to fix it up.

Also, I never took into account grouped lists. Really I don't know why grouped lists need to be any different from ungrouped lists. I'll need to have that in mind when updating this I guess.

avatar roland-d
roland-d - comment - 2 Aug 2016

@okonomiyaki3000 Yeah I know this is old but you know by now that I tend to drag these things out into the light ;) Shall we close this issue for now and can be re-opened or a new one can be made when you have time for it?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5147.

avatar brianteeman brianteeman - change - 22 Aug 2016
Status Pending Information Required
Labels
avatar zero-24
zero-24 - comment - 3 Oct 2016

New PR: #12288

avatar zero-24 zero-24 - change - 3 Oct 2016
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2016-10-03 14:40:24
Closed_By zero-24
Labels
avatar zero-24 zero-24 - close - 3 Oct 2016
avatar okonomiyaki3000
okonomiyaki3000 - comment - 17 Oct 2016

@roland-d I finally got around to doing a little work on it. How do you think it's best to proceed? From here or with a new pr? Just so you know, I don't think it's quite ready to merge yet but anyway I'm ready to continue discussing and working on it.

avatar zero-24
zero-24 - comment - 17 Oct 2016

I have opend a new PR maybe you can fork that branch and do your own PR?

avatar okonomiyaki3000
okonomiyaki3000 - comment - 17 Oct 2016

OK, that sounds good. has some work been done on it then? I guess I'd better go see.

avatar zero-24
zero-24 - comment - 17 Oct 2016

https://github.com/zero-24/joomla-cms/tree/5147

I have just fixed the conflicts

avatar okonomiyaki3000
okonomiyaki3000 - comment - 18 Oct 2016

@zero-24 It looks like that branch needs to be rebased with staging. It might end up being a big hassle. I have a branch that's already been rebased, maybe it's best to make a new PR? or has some work been done on your branch already?

avatar zero-24
zero-24 - comment - 18 Oct 2016

No there is no additional work done.

Add a Comment

Login with GitHub to post a comment