? Success

User tests: Successful: Unsuccessful:

avatar okonomiyaki3000
okonomiyaki3000
20 Nov 2014

Updated to version 4.7.
Release notes are here: http://codemirror.net/doc/releases.html

avatar okonomiyaki3000 okonomiyaki3000 - open - 20 Nov 2014
avatar jissues-bot jissues-bot - change - 20 Nov 2014
Labels Added: ?
avatar brianteeman brianteeman - change - 20 Nov 2014
Category External Library
avatar zero-24
zero-24 - comment - 21 Nov 2014

@test ok here in Backend and Frontend. Any special cases that need to test @okonomiyaki3000?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5145.

avatar zero-24 zero-24 - test_item - 21 Nov 2014 - Tested successfully
avatar okonomiyaki3000
okonomiyaki3000 - comment - 21 Nov 2014

Nope, nothing special here just keeping CM up to date.

avatar infograf768
infograf768 - comment - 22 Nov 2014

I have an issue applying the diff here.

avatar waader
waader - comment - 22 Nov 2014

@test works

Remarks: I checked the different options of the plugin. Everthings works except for the "bracket completion" and the "match brackets" function. Maybe I have a misconception of how this should work - I am not an expierenced code mirror user. So I compared the behaviour to the previous version and could not see any difference. Maybe it didn´t work for some time.
Anyway: in the process of researching this I saw that there is already a newer version 4.8.

@infograf768: I also was not apply to apply the diff. So I used com_patchtester (current build) and also tried it out with the last official beta release. With success.

avatar roland-d
roland-d - comment - 23 Nov 2014

@okonomiyaki3000 Could you update this PR to version 4.8? Thanks.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5145.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 25 Nov 2014

Hmm. This seems to be to staging but I've been rebasing with 3.4-dev. Shall I rebase with staging?

avatar infograf768
infograf768 - comment - 25 Nov 2014

branch we now work on is staging.
The issue here is with the file coffescript/index.html
screen shot 2014-11-25 at 07 27 02

Which original is imho corrupted:
```# JavaScript templating a-la ERB, pilfered from John Resig's

Secrets of the JavaScript Ninja, page 83.

Single-quote fix from Rick Strahl.

With alterations for arbitrary delimiters, and to preserve whitespace.

_.template = (str, data) ->
c = _.templateSettings
endMatch = new RegExp("'(?=[^"+c.end.substr(0, 1)+"]*"+escapeRegExp(c.end)+")","g")
fn = new Function 'obj',
'var p=[],print=function(){p.push.apply(p,arguments);};' +
'with(obj||{}){p.push(\'' +
str.replace(/\r/g, '\r')
.replace(/\n/g, '\n')
.replace(/\t/g, '\t')
.replace(endMatch,"���")
.split("'").join("\'")
.split("���").join("'")
.replace(c.interpolate, "',$1,'")
.split(c.start).join("');")
.split(c.end).join("p.push('") +
"');}return p.join('');"
if data then fn(data) else fn

avatar okonomiyaki3000
okonomiyaki3000 - comment - 25 Nov 2014

This file is entirely irrelevant anyway.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 26 Nov 2014

rebased with staging

avatar infograf768
infograf768 - comment - 26 Nov 2014

I would suggest to first tell codemirror people about the issue I pointed above (even if the file is irrelevant in Joomla), and then, when corrected, propose a PR to the new release as this is not urgent.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 27 Nov 2014

For now I'm just replacing all index.html files with an empty html document (like most joomla directories have). I'll see what I can do about getting a fix into CodeMirror later. I doubt it's very important to them, even if this is corruption, it probably still works the way it's supposed to.

avatar waader
waader - comment - 27 Nov 2014

I made a fresh git clone of staging and tried to apply the patch without success:

error: cannot apply binary patch to 'media/editors/codemirror/addon/tern/tern.js' without full index line
error: media/editors/codemirror/addon/tern/tern.js: patch does not apply
error: cannot apply binary patch to 'media/editors/codemirror/mode/apl/apl.js' without full index line
error: media/editors/codemirror/mode/apl/apl.js: patch does not apply
error: cannot apply binary patch to 'media/editors/codemirror/mode/apl/index.html' without full index line
error: media/editors/codemirror/mode/apl/index.html: patch does not apply
error: patch failed: media/editors/codemirror/mode/coffeescript/index.html:1
error: media/editors/codemirror/mode/coffeescript/index.html: patch does not apply
....

I did the same today with other patches eg. the microdata plugin and that went fine.

avatar okonomiyaki3000
okonomiyaki3000 - comment - 28 Nov 2014

This branch seems to have a lot of issues. I think I'll trash it and make a new one.

avatar okonomiyaki3000 okonomiyaki3000 - close - 28 Nov 2014
avatar okonomiyaki3000
okonomiyaki3000 - comment - 28 Nov 2014

Closing in favor of #5232

avatar okonomiyaki3000 okonomiyaki3000 - close - 28 Nov 2014
avatar okonomiyaki3000 okonomiyaki3000 - change - 28 Nov 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-11-28 06:35:41
avatar okonomiyaki3000 okonomiyaki3000 - head_ref_deleted - 28 Nov 2014

Add a Comment

Login with GitHub to post a comment