@test ok here in Backend and Frontend. Any special cases that need to test @okonomiyaki3000?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5145.

Nope, nothing special here just keeping CM up to date.

I have an issue applying the diff here.

@test works

Remarks: I checked the different options of the plugin. Everthings works except for the "bracket completion" and the "match brackets" function. Maybe I have a misconception of how this should work - I am not an expierenced code mirror user. So I compared the behaviour to the previous version and could not see any difference. Maybe it didn´t work for some time.
Anyway: in the process of researching this I saw that there is already a newer version 4.8.

@infograf768: I also was not apply to apply the diff. So I used com_patchtester (current build) and also tried it out with the last official beta release. With success.

@okonomiyaki3000 Could you update this PR to version 4.8? Thanks.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5145.

Hmm. This seems to be to staging but I've been rebasing with 3.4-dev. Shall I rebase with staging?

branch we now work on is staging.
The issue here is with the file coffescript/index.html

Which original is imho corrupted:
```# JavaScript templating a-la ERB, pilfered from John Resig's

Secrets of the JavaScript Ninja, page 83.

Single-quote fix from Rick Strahl.

With alterations for arbitrary delimiters, and to preserve whitespace.

_.template = (str, data) ->
c = _.templateSettings
endMatch = new RegExp("'(?=[^"+c.end.substr(0, 1)+"]*"+escapeRegExp(c.end)+")","g")
fn = new Function 'obj',
'var p=[],print=function(){p.push.apply(p,arguments);};' +
'with(obj||{}){p.push(\'' +
str.replace(/\r/g, '\r')
.replace(/\n/g, '\n')
.replace(/\t/g, '\t')
.replace(endMatch,"���")
.split("'").join("\'")
.split("���").join("'")
.replace(c.interpolate, "',$1,'")
.split(c.start).join("');")
.split(c.end).join("p.push('") +
"');}return p.join('');"
if data then fn(data) else fn

This file is entirely irrelevant anyway.

rebased with staging

I would suggest to first tell codemirror people about the issue I pointed above (even if the file is irrelevant in Joomla), and then, when corrected, propose a PR to the new release as this is not urgent.

For now I'm just replacing all index.html files with an empty html document (like most joomla directories have). I'll see what I can do about getting a fix into CodeMirror later. I doubt it's very important to them, even if this is corruption, it probably still works the way it's supposed to.

I made a fresh git clone of staging and tried to apply the patch without success:

error: cannot apply binary patch to 'media/editors/codemirror/addon/tern/tern.js' without full index line
error: media/editors/codemirror/addon/tern/tern.js: patch does not apply
error: cannot apply binary patch to 'media/editors/codemirror/mode/apl/apl.js' without full index line
error: media/editors/codemirror/mode/apl/apl.js: patch does not apply
error: cannot apply binary patch to 'media/editors/codemirror/mode/apl/index.html' without full index line
error: media/editors/codemirror/mode/apl/index.html: patch does not apply
error: patch failed: media/editors/codemirror/mode/coffeescript/index.html:1
error: media/editors/codemirror/mode/coffeescript/index.html: patch does not apply
....

I did the same today with other patches eg. the microdata plugin and that went fine.

This branch seems to have a lot of issues. I think I'll trash it and make a new one.

Closing in favor of #5232