? Success

User tests: Successful: Unsuccessful:

avatar dgt41
dgt41
15 Nov 2014

Executive summary

This PR converts the form validation on com_tags to use plain jquery (no mootools call on every form).
Also NO MORE INLINE SCRIPTS!

Testing

Make sure you have some tags

  1. Apply first PR #4888 (!important)
  2. Apply this PR
  3. In the admin area create new menu items for tags (all three options)
  4. go to the new menus and test that everything is still OK

If no javascript errors are logged in your browser’s console and the functionality remains the same, your test is passing in any other case please report the errors here

Please also check these:
administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
Logout and log in to demonstrate the use of noframes without mt.

891a5bc 15 Nov 2014 avatar dgt41 init
avatar dgt41 dgt41 - open - 15 Nov 2014
avatar jissues-bot jissues-bot - change - 15 Nov 2014
Labels Added: ?
avatar zero-24 zero-24 - change - 16 Nov 2014
Category Front End JavaScript
avatar anibalsanchez
anibalsanchez - comment - 17 Nov 2014

@test success. It is just a minor code change. Front-end site works as usual.

avatar roland-d roland-d - alter_testresult - 19 Nov 2014 - anibalsanchez: Tested successfully
avatar roland-d
roland-d - comment - 19 Nov 2014

@smanzi Would you mind testing this one also? Thank you.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5116.

avatar yanivRozenman
yanivRozenman - comment - 20 Nov 2014

@dgt41
After "Apply first PR #4888 (!important)" like you wrote in the instruction test,
i got Error 500
screen shot 2014-11-20 at 16 08 51

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5116.

avatar dgt41
dgt41 - comment - 20 Nov 2014

You don't need to apply #4888 anymore as it is already merged. That's if you re testing with latest dev edition. Ca you share the menu you used?

avatar dgt41
dgt41 - comment - 21 Nov 2014

@yanivRozenman Please check your Joomla version you’re using to test this. If it is the current staging you don’t have to apply #4888 as this is already merged. If you are on 3.3.6 and still getting errors check patch tester. The error message indicates that something gone wrong and the file behavior.php is missing

avatar yanivRozenman
yanivRozenman - comment - 21 Nov 2014

@dgt41 Ok, thanks for the update.
I will check it without #4888 on the current staging

avatar smanzi
smanzi - comment - 25 Nov 2014

@test success

avatar smanzi smanzi - test_item - 25 Nov 2014 - Tested successfully
avatar roland-d roland-d - change - 25 Nov 2014
Status Pending Ready to Commit
avatar roland-d
roland-d - comment - 25 Nov 2014

Moving to RTC as we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5116.

avatar brianteeman brianteeman - change - 29 Nov 2014
Labels Added: ?
avatar Bakual
Bakual - comment - 2 Dec 2014

Merged into staging. Thanks!

avatar zero-24 zero-24 - close - 2 Dec 2014
avatar Bakual Bakual - close - 2 Dec 2014
avatar Bakual Bakual - change - 2 Dec 2014
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2014-12-02 20:13:19
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment