[#5115] - Introduce jquery formvalidator for com_newsfeed ::frontend
- Closed
- 27 Dec 2014
- Medium
- Build: staging
- # 5115
- Diff
- dgt41:_form_jq_com_newsfeed_frontend
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Executive summary
This PR converts the form validation on com_newsfeed to use plain jquery (no mootools call on every form).
Also NO MORE INLINE SCRIPTS!
Testing
- Apply first PR #4888 (!important)
- Apply this PR
- In the admin area create new menu items for newsfeed category
- go to the new menu and test that everything (the list reordering) is still OK
If no javascript errors are logged in your browser’s console and the functionality remains the same, your test is passing in any other case please report the errors here
Please also check these:
administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
Logout and log in to demonstrate the use of noframes without mt.
jissues-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Front End JavaScript |
@smanzi Would you mind testing this one also? Thank you.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5115.
yeap... hold-on...
Dimitris, I'm not into newsfeeds at all, but when I try to create a menu entry for "List News Feeds in Category" I can choose "Uncategorized" only, while I have 2 more categories...
Mind you: this is a fresh install BUT with multilingual already enabled and the other two categories (in which I have articles) are bound to a specific language...
This is for the front end part, what you are describing is the backend. Go to admin->menu create a menu with menu type newsfeed, and visit the front end on that menu. There should be a list of articles with no js errors...
Ooops forgot to tell you that you have to go first to components->newsfeed and set up a feed there!
Ah OK... my ignorance... hold-on...
Grrrrrrr... I'm not getting how all this works... I even don't see the menu item in my front-end...
Spype + TeamViewer, you come to make me a visit?
| Status | Pending | ⇒ | Ready to Commit |
Moving to RTC as we have 2 successful tests.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5115.
brianteeman
- | Labels |
Added:
?
|
||
I can't see what this is being loaded for? If I remove the call to core.js I can't see anything breaking (tested searching and changing pagination). What's this being used for?
There doesn't seem to be a way to change that?
found it:
<p><?php echo JText::_('COM_NEWSFEEDS_NO_ARTICLES'); ?></p>JText needs core.js for the translation of the string
I'm pretty sure the only JText dependency is for using strings in javascript!
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-27 18:24:31 |
| Labels |
Removed:
?
|
||
@test success. It is just a minor code change. Front-end site works as usual.