@dgt41
Buttons (Save -> Cancel) inactive in &view=override&layout=edit
OK in &view=language&layout=edit

@smanzi It should be ok ok now!

@dgt41 Travis is crying... should I test anyway?

@smanzi Travis hasn’t finished yet but he should be ok with this change i made! Go ahead!

@test success

@test success

Moving to RTC as we have 2 successful tests.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5046.

@phproberto can you review this dgt41@82b6a29

Creating an Override, it is OK. However, when the same page is accessed after saving, it loads the Override and generates this error:

SyntaxError: syntax error
var expired = ;
index.p...SERNAME (line 37, col 18)

The error is coming from here:

$expired = ($this->state->get("cache_expired") == 1 ) ? '1' : '';

var expired = ' . $expired . ';

@anibalsanchez stupid mistake, I pushed a correction, sorry about that

@test success!

I was merging your PRs but I totally agree with @Fedik here:

• Functions do not require to wait until DOM is ready
• We are adding here a jQuery dependency not needed

We should try to get as much code in plain JS as possible. I just checked it and we have some jQuery code inside core.js (and it makes jQuery required) but that's an error IMO. Probably we won't remove jQuery until v4.0 but we should keep it clean and independent.

In fact we officially support Mootools and jQuery and using jQuery on core makes it mandatory for everybody.

@phproberto You want me to remove all the jQuery(document).ready(…);
from all the functions not mandatory to have it?
Can do that! gimme some time...

The most important part is not to tie core to other libraries and do not transmit that to other developers as something recommended.

In our code we are loading jQuery and that's done in our own views so that wouldn't be a big problem. But yes, I'd like to see core not mixed with jQuery.

I've created an issue for the existing jQuery code in core.js #5254

Check #5039 #5041

Dammit for the closed ones the changes don’t come thru

Yes they are now merged so we need a new PR for that :(

Shall I do it in one PR or break it down for every component?

One PR is ok as we only need to check that submitform works and it's only 5 components merged.

Thank you @dgt41 :)

Check #5255

I think I cleared the superfluous jQuery calls wherever not necessary!

Thanks!! I'll test it ASAP. I think it's easy because all the toolbar buttons fire them. I'll also add a list of views to test.

Guys, what a great job! I'm ready to test whatever you need. My small contribution...

@smanzi we can help @phproberto with a test #5255, but also I removed some redundant jquery all over those requests...

OK. I'll start testing that everything is working in:

com_admin
com_banners
com_categories
com_contact
com_content
com_finder

If I'm not mistaken I must first sync with latest staging and then apply this and #5255. Correct? Backend is enough, right?

Yep, Sergio those are all backend

And the big list: #5046 #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 #5113

Oh yes... small mistake... forgot about #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 & #5113

@dgt41 I'm going to test the bunch of them (and this and #5255) all applied and then report to each. Is that OK?

Actually if you see the last commit in each of all these you will realize that i just deleted 2 lines

jQuery(document).ready(function() {

and

});

So basically is not that bad as it seems

Yeah, but it is always better be safe than sorry... I'll give a run on all of them...

#5113 is front-end (will test)
#5047 (not in your list) cannot be applied:

The patch could not be applied because it conflicts with a previously applied patch: administrator/components/com_menus/views/item/tmpl/edit_modules.php

Thnks Sergio, #5047 is not touched so no need to test it again and the #5113 is front end (create article)

@test success for this PR
Tested the set of: #5046 #5048 #5049 #5050 #5051 #5052 #5053 #5054 #5056 #5058 #5113 #5255

@phproberto This is still open...

Folks, I had to commit cd70e94

as editing or creating an override was broken

@infograf768 You're right! Sorry, I didn't test that view; I tried installing a new language, but that is not com_languages but com_installer

Is it normal that when I first try to install a new language I find the available languages list populated only by the following?

Albanian
Bahasa Indonesia
Bosnian
EnglishCA
Finnish
FrenchCA
Montenegrin
Portuguese Brazil
Serbian Cyrillic
Serbian Latin
Sinhala
Spanish
Swahili
Tamil
Thai
Turkish
Ukrainian
Uyghur
Vietnamese
Welsh

I find it confusing... I would expect either all available languages or none at all...

Please click on "Find languages". It solves this issue. No idea why we get a limited list. I even get a pkg_weblinks.xml sometimes in that list.

@infograf768 yep, I know I have to click "Find languages" but I find weird to have the languages list "somehow" populated...

Should I open an issue for this?

@smanzi I am on it...

OMG, you are on... EVERYTHING!

@smanzi actually this is my bad...

@dgt41 BTW, I have another that it is surely for you: get in touch on Skype when you have a second...

I am on Skype

@smanzi Actually my previous comment wasn’t supposed to be here. Of course I am not on this one, so go on and open an issue…

ah, OK!!