User tests: Successful: Unsuccessful:
This PR converts the form validation on com_finder to use plain jquery (no mootools call on every form
Labels |
Added:
?
|
Category | ⇒ | JavaScript |
Just overwrite the files, but be careful you might lose installed staff (overwriting a folder in a mac actually replaces the folder
In indexed content try: index, purge, statistics
In content maps try to publish unpublish something
and in search filter try to create a new one
Actually here in com_finder for a missing field we have this:
while in all other components we have this:
IMHO an error is better than a warning, but the associated text used in com_finder is more approriate, and I think it will be correct to display the "Error:" title: is this something under the control of your form validator or is it responsibility of each component?
@test success
In the search filter creation, there is a console Javascript error... it may be unrelated with the validator:
sliderfilter.js
ReferenceError: Class is not defined
FinderFilter = new Class({
@anibalsanchez I am afraid the same error existed before the new code, I tried to sort it out but with no success. This was already broken!
@roland-d this one got 2 good tests as well. As for the search filter creation bug is solved here: #5099 But on that one the PLT has to decide which of the two proposed solutions will finally merge to the codebase. I think @chrisdavenport is following that bug
Status | Pending | ⇒ | Ready to Commit |
Moving to RTC as we have 3 successful tests.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5045.
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-29 22:38:00 |
Labels |
Removed:
?
|
@dgt41 It seems to work, but I'm unable (both with/without this PR) to open any children in Content Maps. Link is the same for every "Title" (Type): /administrator/index.php?option=com_finder&view=maps# Searched in Joomla Issues but can't find anything about this. New bug?
I must say that I'm not a big fan of com_finder as it has serious flaws in multilingual environments and I didn't use it since long...