[#4981] - Merging database and warnings view to service view
- Closed
- 2 Dec 2014
- Medium
- Build: 3.4-dev
- # 4981
- Diff
- Hackwar:simplify_com_installer
- Success continuous-integration/travis-ci The Travis CI build passed Details
User tests: Successful: Unsuccessful:
See the title. This is meant to simplify the interface of Joomla and simply merges 2 views into one. We should do this in other places, too.
Test instructions
- Check which messages you get in the warnings view and the database view before applying this patch.
- Apply the patch.
- Check that the same messages are displayed in the service view
- Force the situations that let messages show up in the warnings or database view and check that the same messages show up in the service view.
jissues-bot
- | Labels |
Added:
?
|
||
The benefit is that we could reduce the needed views. The warnings and database view in the extension manager both do similar things: showing a warning if there is something wrong in the system.
I agree that it could be better for the user to have them in one view instead.
I tested the database part and it showed an issue and the fix button worked. So that part still works.
I forced a warning by lowering the memory_limit below 16M and it also showed the warning as expected.
There is an issue with the browser title where the string is not translated. It shows as COM_INSTALLER_TITLE_service.
Also the accordion could use a visual aid so it's clear that you can toggle something.
@brianteeman This is basically meant as a response to you not wanting us to have the file checker in core, so this implements the merge from that PR as a seperate proposal.
OK - thanks for the explanations.
I am wondering if Service is the best name - but I dont have any
suggestions either ;(
On 4 November 2014 08:24, Hannes Papenberg notifications@github.com wrote:
@brianteeman https://github.com/brianteeman This is basically meant as
a response to you not wanting us to have the file checker in core, so this
implements the merge from that PR as a seperate proposal.—
Reply to this email directly or view it on GitHub
#4981 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
Did not test yet, but I suggest to change the string
COM_INSTALLER_MSG_SERVICE_DATABASE_INFO="Database Information"
to
COM_INSTALLER_MSG_DATABASE_SERVICE_INFO
and alpha order it
@infograf768 It is named COM_INSTALLER_MSG_SERVICE_DATABASE_INFO because it is in COM_INSTALLER, it is a MSG in the SERVICE view and its DATABASE_INFO, similar to the other strings in the file.
ok, ok... then just alpha order it please
Done
Missing this one
COM_INSTALLER_MSG_DATABASE_INFO="Other Information"
+COM_INSTALLER_MSG_SERVICE_DATABASE_INFO="Database Information"
COM_INSTALLER_MSG_DATABASE_OK="Database table structure is up to date."
zero-24
- | Category | ⇒ | Administration UI/UX |
Moved that one, too.
Since the 3.4-dev branch is not used anymore, I'm going to create a new PR against staging.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-02 07:56:57 |
What is the benefit if this?
What problem is this PR addressing?
On 3 November 2014 21:34, Hannes Papenberg notifications@github.com wrote:
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/