[#4980] - Implemented correct punctuations.
- Closed
- 4 Nov 2014
- Medium
- Build: staging
- # 4980
- Diff
- tanay1337:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Full stops should be used instead of Semi-Colons.
jissues-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Code style |
| Status | Pending | ⇒ | Ready to Commit |
Please can you NOT commit this and not set en-GB language strings without checking with a native eb-GB speaker first
Technically you only have a full stop at the end when it is a complete sentence
In addition an en-GB style guide that will cover things like this is currently prepared. So can we wait on making this change if it is indeed needed and make all the style changes at the same time.
TIA
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4980.
see: ecd3bbf
why we add here: ecd3bbf#diff-04c6e90faac2675aa89e2176d2eec7d8R68 a Full stop and for the others e.g. ecd3bbf#diff-04c6e90faac2675aa89e2176d2eec7d8R64 a Semi-Colon?
All other places excluded Line 64 to 67 use a Full stop or question mark? So this PR makes senes to me.
This is why i set it to RTC :D
In en-GB semi-colons are the correct punctuation at the end of a list item with the last in the list being a full stop. As Brian says, a style guide showing this is being prepared (slowly) and will be available for review. If it helps, a list is like one long sentence, separated by semi-colons, which is why there is a full stop/period at the end.
I agree that this should not be merged at the moment but thanks for bringing this up @tanay1337 :)
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-11-04 06:01:27 |
Thanks @tanay1337 moving to RTC
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4980.