See comment on issues

Please fix the following errors:

• Travis failed
• Fatal errror - $input is not defined

Thanks!

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4946.

Personal, I like the the original commit of this PR than the later commit. The reasons is because:

1. It is sorter and simpler.

2. I solve the actual problem (just to prevent we include white space in the search string by mistake). Agree that JFilterInput will clean remove the multibyte white spaces. However, for simple use-case like that, I think php native trim function would be enough:

3. We just use it to prevent white space added to search string by "accident"
4. I think the reason we have to use JFilterInput clean for username just to prevent users from trying to make their username looks the same with an exist one (they try/attemp to do that while in this case, we just prevent users from including the space by accident).
5. I think it is difficult to to enter multibyte white spaces unless you really want to do. For me, I had to google to see how to enter it when I tested the JFilterInput clean with TRIM parameter :D
   

Not sure how other developers think about it.
.

@joomdonation Personally I agree with you. The code looks not nice for such a trivial task.
However I also have to say that it could be done easier in this case. Instead of creating a new method where you have to get the JInput object again, you could just add a line:

$searchstring = $this->_db->quote('%' . $input->getString('searchstring') . '%');
$searchstring = JFilterInput::getInstance()->clean($searchstring, 'TRIM');

@Bakual Agree with your last comment, too. That's what I wanted to say, too. If we want to use JFilterInput, just use the code which you proposed, not creating a new method. Could @bweston92 please update the code as @Bakual proposed ? Then I think we will all be happy :).

@joomdonation @Bakual suggestion doesn't work. Once the percent symbols are around the string it will not trim the white-space within.

The fact I abstracted it into another method is because I didn't want to clutter the code in the search method. Having to do a static call etc is ugly anyhow.

Updated, still don't know why PHP's trim isn't sufficient.

@bweston92 : Yes, sorry, you are correct. The code @Bakual proposed doesn't work, but it gives the idea how we would like the code looks like if we need to use JFilterInput.

As I mentioned in my first comment, I am OK with use PHP native trim method for this case. Maybe @Bakual can give final decision?

Well the code uses the filter way of things, I think it's had enough commits for a tiny update.

Sorry about the wrong code. I just copy pasted

Updated, still don't know why PHP's trim isn't sufficient.

Thanks. Code looks fine now.
Reason is because it would not work for chines/asian people. It's just better this way and since we recently introduced this new filter it makes sense to use it over trim.

Ok, merge when you're ready.

@test
Fine here. thanks