[#4945] - Language manager should trim the search.
- Closed
- 28 Oct 2014
- Low
- Build: master
- # 4945
Steps to reproduce the issue
Go to the language manager, click "New" search for a language translation with a space prefix or suffix. This happens sometimes when copying a string from the browser and pasting it.
Expected result
I'd prefer if it trimmed the input.
Actual result
It doesn't trim the input.
System information (as much as possible)
PHP
Additional comments
Votes
Sorry, can't see no trim in JFilterInput. Also I'm sure trimming white-space is the same how-ever it is implemented.
No, it is not. We also have Asian multibyte white spaces.
code could be similar to
$data['title'] = JFilterInput::getInstance()->clean($data['title'], 'TRIM');
see:
https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/filter/input.php#L258
thanks
Hmm I'd rather not have another ugly static method call, but oh-well will update.
Updated PR.
We have a PR (#4946), I will close this issue entry. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4945.
zero-24
- | Status | New | ⇒ | Closed |
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-28 12:57:19 |
Set to "closed" on behalf of @Kubik-Rubik by The JTracker Application at issues.joomla.org/joomla-cms/4945
| Labels |
Added:
?
|
||
Please use the new TRIM method in JFilterInput