Thanks JM. From a quick look at the code, I think we can improve the code alitle (in the file plugins/system/languagefilter/languagefilter.php). I think we don't have to definine new property $homepages of PlgSystemLanguageFilter class, just use the old $homes property would be enough. Actually, in PlgSystemLanguageFilter, I think we only need to change one line of code:

From

self::$homes        = MultilangstatusHelper::getHomes();

To

self::$homes         = MultilangstatusHelper::getHomepages();

and it should work well. No need for other changes like you did in the PR (I might be wrong, will test and review the code carefully when I got home)

Test on 3.3.6 : "PHP warning" in PHP error log file.
Cleaning PHP error log, patch, test: no more error in log file.
Thanks.

@joomdonation
You are right. Will update

Thanks JM :).

One more test to commit

@test: OK

Before patch, there are warning in error logs like this

[Tue Oct 28 19:12:28.602154 2014] [:error] [pid 1852:tid 916] [client ::1:60257] PHP Warning: Illegal string offset '*' in E:\www\testinstallation\plugins\system\languagefilter\languagefilter.php on line 535, referer: http://localhost/testinstallation/index.php/fr/
[Tue Oct 28 19:12:28.602154 2014] [:error] [pid 1852:tid 916] [client ::1:60257] PHP Notice: Trying to get property of non-object in E:\www\testinstallation\plugins\system\languagefilter\languagefilter.php on line 535, referer: http://localhost/testinstallation/index.php/fr/

After path, no warnings anymore.

Thanks for testing.

Also ported to 2.5.x

Hello all,

after the small fix i get this notices on my site:

Notice: Undefined index: language in /plugins/system/languagefilter/languagefilter.php on line 506

Notice: Undefined property: stdClass::$id in /plugins/system/languagefilter/languagefilter.php on line 535

After i log me in, the site redirect me to the english site and not back to my german site.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4944.

@Markezzz
2.5 or staging?

We use at the moment Joomla! 3.3.6 Stable.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4944.

You should never patch only partly a former version.
Please test locally with your database on staging, as there were other changes too.
https://github.com/joomla/joomla-cms/archive/staging.zip