If this gets merged the documentation here needs also to be updated. Actually this is already outdated as the validate.js is jquery dependent since 3.3

@dgt41 administrator/index.php?option=com_users&view=mail issues errors (missing subject and/or message) in pop (no mt, just basic pop-up...) Is this expected?

@smanzi Yes this is expected behavior

@test success

@test success

• administrator/index.php?option=com_checkin should demonstrate multiselect without mt OK

-administrator/index.php?option=com_users&view=mail should demonstrate multiselect without mt
OK

• administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
  OK

• administrator/index.php?option=com_admin&view=sysinfo should demonstrate highlighter.js without mt
  OK ... but sysinfo does not load highlighter.js. Tested with com_finder in front-end site, searching for a keyword and disabling everything but "Highlight Search Terms"

• Login - Logout without mt
  OK
  
  
  This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4888.

Some heads up informations:
These PRs have already two passing tests:
#5039 joomla/joomla-cms Introduce jquery formvalidator for com_admin
#5041 joomla/joomla-cms Introduce jquery formvalidator for com_banners
#5042 joomla/joomla-cms Introduce jquery formvalidator for com_config
#5043 joomla/joomla-cms Introduce jquery formvalidator for com_contact
#5044 joomla/joomla-cms Introduce jquery formvalidator for com_content
#5045 joomla/joomla-cms Introduce jquery formvalidator for com_finder
#5046 joomla/joomla-cms Introduce jquery formvalidator for com_languages
#5047 joomla/joomla-cms Introduce jquery formvalidator for com_menus
#5048 joomla/joomla-cms Introduce jquery formvalidator for com_messages
#5049 joomla/joomla-cms Introduce jquery formvalidator for com_modules
#5050 joomla/joomla-cms Introduce jquery formvalidator for com_newsfeed
#5051 joomla/joomla-cms Introduce jquery formvalidator for com_plugins
#5052 joomla/joomla-cms Introduce jquery formvalidator for com_redirect
#5053 joomla/joomla-cms Introduce jquery formvalidator for com_tags
#5054 joomla/joomla-cms Introduce jquery formvalidator for com_templates
#5056 joomla/joomla-cms Introduce jquery formvalidator for com_config ::frontend
#5058 joomla/joomla-cms Introduce jquery formvalidator for com_users
# 18 joomla-extensions/weblinks Introduce jquery formvalidator for com_weblinks

These need tests:
#5128 Smart search suggestion script from mootools to jquery
#5112 joomla/joomla-cms Introduce jquery formvalidator for com_contact ::frontend
#5113 joomla/joomla-cms Introduce jquery formvalidator for com_content ::frontend
#5114 joomla/joomla-cms Introduce jquery formvalidator for com_mailto ::frontend
#5115 joomla/joomla-cms Introduce jquery formvalidator for com_newsfeed ::frontend
#5116 joomla/joomla-cms Introduce jquery formvalidator for com_tags ::frontend
#5117 joomla/joomla-cms Introduce jquery formvalidator for com_wrapper ::frontend

And this one needs only review for typos:
#4895 joomla/joomla-cms Convert mootools document.id() to agnostic document.getElementId()

Question for PLT @Bakual, @infograf768 @chrisdavenport :
Any considerations for 3.4 inclusion?

@dgt41 Dimitris, link #18 above is broken: it should have been joomla-extensions/weblinks#18

@smanzi updated! Thanks Sergio!

@test success
Since we have at least 3 successfull tests, I'd say this could be merged. Can someone set this to RTC?

We have 3 successful tests, moving to RTC.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4888.

@dgt41 I can no longer apply this patch, I get this error:
error: patch failed: layouts/joomla/toolbar/batch.php:9
error: layouts/joomla/toolbar/batch.php: patch does not apply

Can you check?

@roland-d I guess patch tester had enough of my code ????. Still good here:

@dgt41 I am not using the patch tester but the Git command line so I can see any codestyle issues as well. As opposed to the patch tester, Git doesn't replace the complete file but applies the actual diff.

I have restarted the Travis build to see what it says.

Line 9 is blank in that file either in my version or the original. I am not a git expert, but is there some caching you can flush?

maybe this: http://stackoverflow.com/questions/12661306/git-rm-cached-file-vs-git-reset-file
Not that one, this: http://richardjoo.wordpress.com/2012/12/21/how-to-clear-git-cache/

@dgt41 I found it, it is not my installation but the file in this diff is outdated. The current staging has a new commit after your change on this batch.php file. See here:
49fc080
It adds a line after line 12, that is why I can't apply the patch.

Do I need to rebase this?

Simply pull in the changes. You don't need to rebase.

I done something pretty stupid when I created this, instead of the proper origin: joomla-cms/staging I used my forked one. If I do anything this will be ruined big time! But now I figure it out how to use tower ????.
Seriously now, sorry for this awkward situation

When there is a will there’s a way

using gitshell I think it is:

git checkout yourbranch
git fetch upstream/pull/nnnn
git merge

@smanzi Thanks I am using a gui tool tower, which for some time I was misusing it. But thanks for the info!

I don't know with your GUI, but with the GUI provided by GitHub there are things you can't do and must use git commands (in gitshell, which is provided together with the GUI)

@dgt41 Thanks, PR applies no problem and Travis is happy.
@test: Works as expected.

@roland-d Any guidance for the documentation update? What we have is already outdated as from 3.3 we use jquery validation code

@dgt41 Let's ask @Hutchy68 as he is the one leading the documentation efforts. What can be done about the documentation Tom?