PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar muhme
muhme
25 Oct 2026
  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

The current 5.4-dev branch contains phpcs errors. This PR fixes these errors.

The findings are fixed with:

libraries/vendor/bin/phpcbf --standard=ruleset.xml {files}

Any changes to the CI that may be necessary to avoid such situations will then be discussed within the maintainer team.

Testing Instructions

Running PHP Code Sniffer in development environment on 5.4-dev branch:
libraries/vendor/bin/phpcs --extensions=php -p --standard=ruleset.xml .

Actual result BEFORE applying this Pull Request

5 finding in 2 files:

FILE: /var/www/html/administrator/components/com_installer/tmpl/update/default.php
----------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------
 108 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 111 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
 112 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
----------------------------------------------------------------------------------

FILE: /var/www/html/administrator/components/com_fields/src/Model/FieldModel.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
 1009 | ERROR | [x] The first expression of a multi-line control structure must be on the line after the opening
      |       |     parenthesis
 1011 | ERROR | [x] The closing parenthesis of a multi-line control structure must be on the line after the last
      |       |     expression
-----------------------------------------------------------------------------------------------------------------------

Expected result AFTER applying this Pull Request

No findings anymore.

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar muhme muhme - open - 25 Oct 2026
avatar muhme muhme - change - 25 Oct 2026
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2026
Category ⇒ Administration com_fields com_installer
avatar brianteeman
brianteeman - comment - 25 Oct 2026

I thought files in the /tmpl folders were excluded

avatar richard67
richard67 - comment - 26 Oct 2026

I thought files in the /tmpl folders were excluded

@brianteeman For the php-cs-fixer that's the case.

Anyway the CS fixes made with the PR are right, also for the tmpl file where the only tabs are replaced with spaces for correct indentation.

avatar richard67 richard67 - change - 26 Oct 2026
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2026-10-26 19:24:44
Closed_By ⇒ richard67
Labels Added: PR-5.4-dev
avatar richard67 richard67 - close - 26 Oct 2026
avatar richard67 richard67 - merge - 26 Oct 2026
avatar richard67
richard67 - comment - 26 Oct 2026

Thanks @muhme .

Add a Comment

Login with GitHub to post a comment