User tests: Successful: Unsuccessful:
The current 5.4-dev branch contains phpcs errors. This PR fixes these errors.
The findings are fixed with:
libraries/vendor/bin/phpcbf --standard=ruleset.xml {files}
Any changes to the CI that may be necessary to avoid such situations will then be discussed within the maintainer team.
Running PHP Code Sniffer in development environment on 5.4-dev branch:
libraries/vendor/bin/phpcs --extensions=php -p --standard=ruleset.xml .
5 finding in 2 files:
FILE: /var/www/html/administrator/components/com_installer/tmpl/update/default.php
----------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------
108 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
111 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
112 | ERROR | [x] Spaces must be used to indent lines; tabs are not allowed
----------------------------------------------------------------------------------
FILE: /var/www/html/administrator/components/com_fields/src/Model/FieldModel.php
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
1009 | ERROR | [x] The first expression of a multi-line control structure must be on the line after the opening
| | parenthesis
1011 | ERROR | [x] The closing parenthesis of a multi-line control structure must be on the line after the last
| | expression
-----------------------------------------------------------------------------------------------------------------------
No findings anymore.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_fields com_installer |
I thought files in the /tmpl folders were excluded
@brianteeman For the php-cs-fixer that's the case.
Anyway the CS fixes made with the PR are right, also for the tmpl file where the only tabs are replaced with spaces for correct indentation.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-10-26 19:24:44 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
PR-5.4-dev
|
||
I thought files in the /tmpl folders were excluded