User tests: Successful: Unsuccessful:
Pull Request resolves #48619 .
Fixes an issue in Safari where clicking the Today, Clear, or Close buttons in the Joomla calendar can cause the calendar to close before the button's click handler executes. In other words the buttons do nothing
The change is limited to calendar.es5.js and the affected calendar instance. It does not change the behaviour of other buttons elsewhere on the page.
In an article fo to the publishing field
Click the calendar icon to open the date picker.
Click the Today button.
The calendar should set the date to today and close.
Open the calendar again and click Clear.
The calendar should clear the selected date as expected.
Open the calendar again and click Close.
The calendar should close without applying an unintended action.
Repeat the tests using Safari.
Repeat the tests using another supported browser to confirm that existing behaviour is unchanged.
This needs testing by users on chrome and firefox to confirm that the calendar buttons still work as expected AND safari users to confirm that the bug is fixed
Maintainers I would suggest at least 2 tests on safari and 2 tests on other browsers
Today, Clear and Close buttons do nothing
Buttons work as expected
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | JavaScript NPM Change |
| Title |
|
||||||
I have tested this item ✅ successfully on 299cf87
I have tested this successfully. Thanks @brianteeman.
I used Safari 26.6.2 (21624.5.1.11.3) on a MacBook Pro M4 / running Tahoe 26.6.2 (25G83). I also tested it against Chrome 156.0.8078.48 (Official Build) (arm64) latest version and Opera One(version: 138.0.6044.24) (arm64) latest versions as well as Firefox 158.0.1 (aarch64) latest version.
I have tested this item ✅ successfully on 299cf87
Tested on Safari and Chrome (macOS): Today, Clear and Close buttons work as expected.
I have tested this item ✅ successfully on 299cf87
Tested on Safari and Chrome (macOS): Today, Clear and Close buttons work as expected.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
bug
PR-6.2-dev
|
||
RTC
RTC
I have tested this item ✅ successfully on 299cf87
I have tested this successfully. Thanks @brianteeman.
I used Safari 26.6.2 (21624.5.1.11.3) on a MacBook Pro M4 / running Tahoe 26.6.2 (25G83). I also tested it against Chrome 156.0.8078.48 (Official Build) (arm64) latest version and Opera One(version: 138.0.6044.24) (arm64) latest versions as well as Firefox 158.0.1 (aarch64) latest version.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48654.