User tests: Successful: Unsuccessful:
Pull Request resolves # .
This pull request (PR) updates the lists of files and folder to be deleted on update in script.php to the latest changes in the 7.0-dev branch.
In detail files and folders are added due to following merged PRs:
PR #47874 file administrator/components/com_actionlogs/src/Field/LogcreatorField.php
PR #45856 following folders and helper PHP files inside:
administrator/components/com_banners/helpersadministrator/components/com_categories/helpersadministrator/components/com_contact/helpersadministrator/components/com_content/helpersadministrator/components/com_contenthistory/helpersadministrator/components/com_fields/helpersadministrator/components/com_finder/helpersadministrator/components/com_installer/helpersadministrator/components/com_menus/helpersadministrator/components/com_modules/helpersadministrator/components/com_newsfeeds/helpersadministrator/components/com_plugins/helpersadministrator/components/com_redirect/helpersadministrator/components/com_templates/helpersadministrator/components/com_users/helpersPR #47937 folder components/com_banners/src/Helper and file BannerHelper.php
PR #45857 following folders and helper PHP files inside:
components/com_contact/helperscomponents/com_content/helperscomponents/com_finder/helperscomponents/com_newsfeeds/helperscomponents/com_tags/helpersPR #47930 files:
layouts/joomla/form/field/radiobasic.phplibraries/src/Form/Field/RadiobasicField.phpPR #44237 following folders and PHP files inside:
libraries/phpasslibraries/src/Cryptlibraries/src/Crypt/CipherPR #47884 files:
layouts/joomla/content/icons/create.phplayouts/joomla/html/batch/user.phpPR #47913 file plugins/editors/tinymce/src/Field/UploaddirsField.php
Code review: Check the changes made by this PR and compare the latest 7.0 nightly build's installation zip package with the latest 6.3 nightly build's installation zip package.
Or if you want to make a real test:
Update from a current 6.3-dev branch or the latest 6.3 nightly build to the latest 7.0 nightly build for the actual result, and update from a current 6.3-dev branch or the latest 6.3 nightly build to the patched package or custom update URL created by Drone for this PR for the expected result.
After an update from a current 6.3-dev branch or the latest 6.3 nightly build to the latest 7.0 nightly build, the files and folders handled with this PR are still present.
After an update from a current 6.3-dev branch or the latest 6.3 nightly build to the patched package or custom update URL created by Drone for this PR, the files and folders handled with this PR have been deleted.
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Administration com_admin |
| Labels |
Added:
Conflicting Files
PR-7.0-dev
|
||
With the removal of '/libraries/phpass/PasswordHash.php',
dont we need an sql update to remove it from the extensions table
With the removal of
'/libraries/phpass/PasswordHash.php',dont we need an sql update to remove it from the extensions table
@brianteeman Indeed, see e.g. https://github.com/joomla/joomla-cms/blob/6.2-dev/installation/sql/mysql/base.sql#L200
And it also needs to be removed from the extensions helper: https://github.com/joomla/joomla-cms/blob/6.2-dev/libraries/src/Extension/ExtensionHelper.php#L105
@Hackwar As you had made PR #44237 : Can you confirm this? Can/shall we remove the libraries/phpass extension completely?
This pull request has conflicts, please resolve those before we can evaluate the pull request.