User tests: Successful: Unsuccessful:
The inline help toggle forgets its state on every page load, so anyone who keeps the descriptions open has to press the button again after each save or reload.
This adds an opt-in storage attribute to the form's inline help config:
<config>
<inlinehelp button="show" storage="local"/>
</config>When it is set, the toggle state is kept in localStorage, keyed by the toggle class and the page URL (path + query string), so each form remembers its own state. Only the visible state is stored; hiding the help removes the key.
FormView::addToolbar() reads storage from the form XML and passes it to the button.InlinehelpButton gets a storage option, rendered as data-storage.inlinehelp.es6.js restores and saves the state only when the button carries data-storage="local". Storage access is wrapped in try/catch, so blocked storage (private mode, disabled site data) falls back to the current behaviour.Forms without the attribute are unchanged.
npm run build:js.administrator/components/com_content/forms/article.xml, change <inlinehelp button="show"/> to <inlinehelp button="show" storage="local"/>.The inline help is hidden again after every reload, on every form.
joomla.inlinehelp.* key is gone from localStorage.localStorage — unchanged behaviour.Please select:
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries JavaScript NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-6.3-dev
|
||
I have tested this item ✅ successfully on bbfa22e
Hello @mvanvu, thank you for your contribution and this PR fix (as pointed out by Brian, really nice idea and removes an annoyance).
I have tested this successfully - I just have 1 small question, I have tried multiple times the BEFORE and AFTER scenario and I noticed a performance difference between BEFORE and AFTER which perhaps is not widespread and therefore a non-issue but in my testing was significant enough to see a degradation (I have a video if need be).
Joomla 6.3 Nightly Build from today, just Joomla Patch Tester and RegularLabs Cache plugin installed, Joomla SEF/URL rewriting on.
I cleared cache before each run as a baseline.
Without the PR, the Toggle Inline Help gets visually created next to the Cancel button and almost instantly moves to the right.
Without the PR, the same THING happens but there is a noticeable delay that does not exist when the PR fix is NOT applied.
I have done each run 5 times to make sure it was not a temp WiFi glitch.
Is that expected? is that due to the code change or is it indeed a temp wifi, local network, hosting situation or something else that is unimportant.
Here is the VIDEO without the PR applied:
Here is the VIDEO with the PR applied:
(I realize the video is short but I hope it can illustrate the delay/speed difference)
I have tested this item ✅ successfully on bbfa22e
Hello @mvanvu, thank you for your contribution and this PR fix (as pointed out by Brian, really nice idea and removes an annoyance).
I have tested this successfully - I just have 1 small question, I have tried multiple times the BEFORE and AFTER scenario and I noticed a performance difference between BEFORE and AFTER which perhaps is not widespread and therefore a non-issue but in my testing was significant enough to see a degradation (I have a video if need be).
Joomla 6.3 Nightly Build from today, just Joomla Patch Tester and RegularLabs Cache plugin installed, Joomla SEF/URL rewriting on.
I cleared cache before each run as a baseline.
Without the PR, the Toggle Inline Help gets visually created next to the Cancel button and almost instantly moves to the right.
Without the PR, the same THING happens but there is a noticeable delay that does not exist when the PR fix is NOT applied.
I have done each run 5 times to make sure it was not a temp WiFi glitch.
Is that expected? is that due to the code change or is it indeed a temp wifi, local network, hosting situation or something else that is unimportant.
Here is the VIDEO without the PR applied:
Here is the VIDEO with the PR applied:
(I realize the video is short but I hope it can illustrate the delay/speed difference)
I have tested this item ✅ successfully on bbfa22e
Hello @mvanvu, thank you for your contribution and this PR fix (as pointed out by Brian, really nice idea and removes an annoyance).
I have tested this successfully - I just have 1 small question, I have tried multiple times the BEFORE and AFTER scenario and I noticed a performance difference between BEFORE and AFTER which perhaps is not widespread and therefore a non-issue but in my testing was significant enough to see a degradation (I have a video if need be).
Joomla 6.3 Nightly Build from today, just Joomla Patch Tester and RegularLabs Cache plugin installed, Joomla SEF/URL rewriting on.
I cleared cache before each run as a baseline.
Without the PR, the Toggle Inline Help gets visually created next to the Cancel button and almost instantly moves to the right.
Without the PR, the same THING happens but there is a noticeable delay that does not exist when the PR fix is NOT applied.
I have done each run 5 times to make sure it was not a temp WiFi glitch.
Is that expected? is that due to the code change or is it indeed a temp wifi, local network, hosting situation or something else that is unimportant.
Here is the VIDEO without the PR applied:
https://github.com/user-attachments/assets/3ea0f63a-3529-40dd-988d-28c66499d2b3
Here is the VIDEO with the PR applied:
https://github.com/user-attachments/assets/dbe047c2-1f56-49f4-a5b3-0f6c5d693b2c
(I realize the video is short but I hope it can illustrate the delay/speed difference)
I have tested this item ✅ successfully on bbfa22e
Hello @mvanvu, thank you for your contribution and this PR fix (as pointed out by Brian, really nice idea and removes an annoyance).
I have tested this successfully - I just have 1 small question, I have tried multiple times the BEFORE and AFTER scenario and I noticed a performance difference between BEFORE and AFTER which perhaps is not widespread and therefore a non-issue but in my testing was significant enough to see a degradation (I made 2 videos attached below to help show the difference).
Joomla 6.3 Nightly Build from today, just Joomla Patch Tester and RegularLabs Cache plugin installed, Joomla SEF/URL rewriting on.
I cleared cache before each run as a baseline.
Without the PR, the Toggle Inline Help gets visually created next to the Cancel button and almost instantly moves to the right.
Without the PR, the same THING happens but there is a noticeable delay that does not exist when the PR fix is NOT applied.
I have done each run 5 times to make sure it was not a temp WiFi glitch.
Is that expected? is that due to the code change or is it indeed a temp wifi, local network, hosting situation or something else that is unimportant.
Here is the VIDEO without the PR applied:
https://github.com/user-attachments/assets/3ea0f63a-3529-40dd-988d-28c66499d2b3
Here is the VIDEO with the PR applied:
https://github.com/user-attachments/assets/dbe047c2-1f56-49f4-a5b3-0f6c5d693b2c
(I realize the video is short but I hope it can illustrate the delay/speed difference)
I have tested this item ✅ successfully on bbfa22e
Hello @mvanvu, thank you for your contribution and this PR fix (as pointed out by Brian, really nice idea and removes an annoyance).
I have tested this successfully - I just have 1 small question, I have tried multiple times the BEFORE and AFTER scenario and I noticed a performance difference between BEFORE and AFTER which perhaps is not widespread and therefore a non-issue but in my testing was significant enough to see a degradation (I made 2 videos attached below to help show the difference).
Joomla 6.3 Nightly Build from today, just Joomla Patch Tester and RegularLabs Cache plugin installed, Joomla SEF/URL rewriting on.
I cleared cache before each run as a baseline.
Without the PR, the Toggle Inline Help gets visually created next to the Cancel button and almost instantly moves to the right.
Without the PR, the same THING happens but there is a noticeable delay that does not exist when the PR fix is NOT applied.
I have done each run 5 times to make sure it was not a temp WiFi glitch.
Is that expected? is that due to the code change, the nature of the LocalStorage update or is it indeed a temp wifi, local network, hosting situation or something else that is unimportant.
Here is the VIDEO without the PR applied:
https://github.com/user-attachments/assets/3ea0f63a-3529-40dd-988d-28c66499d2b3
Here is the VIDEO with the PR applied:
https://github.com/user-attachments/assets/dbe047c2-1f56-49f4-a5b3-0f6c5d693b2c
(I realize the video is short but I hope it can illustrate the delay/speed difference)
There needs to be an indicator that the show help is on or off
Nice idea