[#48509] - [6.3] TinyMCE paste from word
- Ready to Commit
- Medium
- Build: 6.3-dev
- # 48509
- Diff
- brianteeman:tinymce_paste_from_word
User tests: Successful: Unsuccessful:
Pull Request resolves # .
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
When we upgraded to TinyMCE 6 with joomla 5.0 we missed that the "paste from word" functionality was removed from the paste plugin and now only exists in the non-free paste plugin.
This PR follows the advice from TinyMCE to implement a forked version of the original paste plugin with just the paste from word funtionality.
[i dont have a current copy of ms word to test with]
Note: I have not added a configuration option for this - its always enabled but an option could be added if maintainers require it
This PR is following the recommendations from tinymce about using their paste from word code
Testing Instructions
this is a js change so either test with a prebuilt package or use npm i to build the js
Use a sample word doc (for example from https://sample-videos.com/download-sample-doc-file.php or https://file-examples.com/index.php/sample-documents-download/sample-doc-download/)
Copy and paste the doc into Joomla. Save and then view the source
also test with tinymce filter settings for Joomla Text Filter yes and no
Actual result BEFORE applying this Pull Request
lots of mso tags etc in the source
example
<li class="MsoNormal" style="mso-list: l0 level1 lfo2; tab-stops: list 36.0pt;"><span lang="EN-US">First item of bulleted list. </span></li>
<li class="MsoNormal" style="mso-list: l0 level1 lfo2; tab-stops: list 36.0pt;"><span lang="EN-US">Second item of bulleted list.</span></li>
Expected result AFTER applying this Pull Request
no mso tags in the source
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change Front End Plugins |
I have tested this item 🔴 unsuccessfully on be1b8fd
I’m sure I’ve understood the testing instructions correctly.
I used Microsoft Word 2024.
I downloaded the 1Mb sample text.
I copied, pasted and saved the Joomla article; I viewed the code, which still showed the Microsoft Word tags; I ran the test both with and without the Joomla text filter.
The result remained the same: it still displays the Word tags.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
I have tested this item 🔴 unsuccessfully on be1b8fd
I’m sure I’m not sure I’ve understood the testing instructions correctly.
I used Microsoft Word 2024.
I downloaded the 1Mb sample text.
I copied, pasted and saved the Joomla article; I viewed the code, which still showed the Microsoft Word tags; I ran the test both with and without the Joomla text filter.
The result remained the same: it still displays the Word tags.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
I have tested this item 🔴 unsuccessfully on be1b8fd
I’m not sure I’ve understood the testing instructions correctly.
I used Microsoft Word 2024.
I downloaded the 1Mb sample text.
I copied, pasted and saved the Joomla article; I viewed the code, which still showed the Microsoft Word tags; I ran the test both with and without the Joomla text filter.
The result remained the same: it still displays the Word tags.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
thanks for testing - i will check and see why its not doing anything
| Labels |
Added:
NPM Resource Changed
PR-6.3-dev
|
||
| Category | NPM Change Front End Plugins | ⇒ | NPM Change JavaScript Front End Plugins |
I have tested this item 🔴 unsuccessfully on be1b8fd
I used this package "Joomla_6.2.0-beta2-dev+pr.48509-Development-Full_Package.zip" for the test.
I tested it using the On/Off option in the TinyMCE editor.
Downloaded a test Word document, copied all the content, and pasted it into an article.
The page's source code contains code generated by Word: mso-list, mso-pagination, mso-yfti-irow, mso-list, ecc.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
I have tested this item 🔴 unsuccessfully on be1b8fd
I used this package "Joomla_6.2.0-beta2-dev+pr.48509-Development-Full_Package.zip" for the test.
I tested it using the On/Off option in the TinyMCE editor.
Downloaded a test Word document, copied all the content, and pasted it into an article.
The page's source code contains code generated by Word: mso-list, mso-pagination, mso-yfti-irow, mso-list, ecc.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
@mariantanase @gioacchino54 I made a mistake and missed adding a file - the important one.
New packagesare available now https://artifacts.joomla.org/drone/joomla/joomla-cms/6.3-dev/48509/downloads/96719/
thanks in advance for testing
I have tested this item ✅ successfully on 55c949d
Hi Brian,
I repeat the test with the updated package. You were right, the missing file was very important :)
Now, the source code is clean, without those mso tags. There are no more Word tags.
Tested with and without Joomla Text Filter.
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
I have tested this item ✅ successfully on 55c949d
Hi Brian,
I repeat the test with the updated package. You were right, the missing file was very important :)
Now, the source code is clean, without those mso tags. There are no more Word tags.
Tested with and without Joomla Text Filter.
Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
I have tested this item ✅ successfully on 55c949d
I ran the test again with the Joomla Text Filter both enabled and disabled.
I copied and pasted the 1 MB Microsoft Word file, and also a 1.7 MB Word file generated by exporting a PDF using Acrobat – no problems at all. All the Microsoft Word tags are removed, and in the case of the latter file, the words are not joined together, with the spaces between them preserved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
I have tested this item ✅ successfully on 55c949d
I ran the test again with the Joomla Text Filter both enabled and disabled.
I copied and pasted the 1 MB Microsoft Word file, and also a 1.7 MB Word file generated by exporting a PDF using Acrobat – no problems at all. All the Microsoft Word tags are removed, and in the case of the latter file, the words are not joined together, with the spaces between them preserved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
I have tested this item ✅ successfully on 55c949d
I tested it with several .doc and .docx files and didn’t encounter any problems whatsoever
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
I have tested this item ✅ successfully on 55c949d
I tested it with several .doc and .docx files and didn’t encounter any problems whatsoever
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.
I have tested this item 🔴 unsuccessfully on be1b8fd
I’m sure I’ve understood the testing instructions correctly.
I used Microsoft Word 2024.
I downloaded the 1Mb sample text.
I copied, pasted and saved the Joomla article; I viewed the code, which still showed the Microsoft Word tags; I ran the test both with and without the Joomla text filter.
The result remained the same: it still displays the Word tags.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/48509.