[#4811] - Implementing popup warning if no items are selected
- Closed
- 18 Oct 2014
- Medium
- Build: staging
- # 4811
- Diff
- RCheesley:4767-popups-com-messages
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This fixes issue #4767 by implementing a popup to warn if no items have been selected.
The alert box should be displayed for Mark as Read & Mark as Unread on Messaging page.
jissues-bot
- | Labels |
Added:
?
|
||
nicksavov
- | Labels |
Added:
?
|
||
mtmeyrick
- 
zero-24
- | Category | ⇒ | Administration UI/UX |
Great work and congrats on your first Pull Request setting to RTC
| Status | Pending | ⇒ | Ready to Commit |
@RCheesley, for Travis to success, you need to add a space after comma : ", true" ;-)
In my opinion, is alert popup box needed, as we have already working the J alert message ?
Before PR - Joomla alert message :
After PR - Alert popup :
I know it is like that elsewhere, but some users never see alert popup (a browser could block them), it could be more secure to used Joomla integrated alert message system everywhere ?
In case Alert popup is the recommended usage, @test success !
Welcome @RCheesley for your first PR, and not the last one ? ;-)
OK I'll take a look at this and see what I can work out myself ;)
| Labels |
Added:
?
|
||
phproberto
- | Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-10-18 02:56:44 |
@test OK, works perfectly!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4811.