Pending

User tests: Successful: Unsuccessful:

avatar RiteshGite
RiteshGite
26 Apr 2026

Pull Request resolves #47675

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Fixed the isNested variable to properly handle data-nested="false" attribute by converting the string value to a boolean.

Testing Instructions

  1. Set data-nested="false" on a draggable table
  2. Try to drag and drop rows
  3. Verify that sorting works correctly
  4. Test with data-nested="true" to ensure nesting still works

Actual result BEFORE applying this Pull Request

When data-nested="false" is set, drag-and-drop sorting does not work because the string "false" is treated as truthy in JavaScript, causing the condition if (isNested) to incorrectly evaluate to true.

Expected result AFTER applying this Pull Request

Both data-nested="true" and data-nested="false" work correctly. The fix explicitly converts the dataset string value to a boolean using isNested = container.dataset.nested === 'true';

Link to documentations

avatar RiteshGite RiteshGite - open - 26 Apr 2026
avatar RiteshGite RiteshGite - change - 26 Apr 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Apr 2026
Category JavaScript Repository NPM Change
avatar BeginnerJoomlaCom
BeginnerJoomlaCom - comment - 26 Apr 2026

Please use the Pull Request-Template.

avatar RiteshGite RiteshGite - change - 26 Apr 2026
The description was changed
avatar RiteshGite RiteshGite - edited - 26 Apr 2026

Add a Comment

Login with GitHub to post a comment