I have tested this item ✅ successfully on 9769b06

I have successfully tested this! Merci @cyrez ;)

did you also test this with non-gregorian calendars such as jalali with the farsi language pack

did you also test this with non-gregorian calendars such as jalali with the farsi language pack

The code change should not affect non-gregorian calendars, as same issue, and same check for non-gregorian calendar for input event handler.
But i just tested with Farsi. Same issue before. After applying the patch, the issue is fixed as well (eg. you can pick a day in the calendar, set manually the time (for example, enter for the first 2 digits "۰۰") and on save, it keeps now the manual edit from the input.

Of course, another test with a non-gregorian calendar would be better ;-)

I have tested this item ✅ successfully on 9769b06

Manual time edits in the Jalali(farsi) calendar saves successfully with patch.

I have tested this item 🔴 unsuccessfully on 9769b06

Changing my test result to Unsuccessful.

I previously marked this as a successful test but I need to retract that. Due to my lack of familiarity with Farsi and the Jalali calendar numerals, I misinterpreted the output during my testing and incorrectly thought it had saved properly.

To be safe I am changing my vote to unsuccessful for now. I highly recommend that someone who better understand Farsi gives this a proper test.

Sorry for the confusion!

I have tested this item 🔴 unsuccessfully on 9769b06

Changing my test result to Unsuccessful.

I previously marked this as a successful test but I need to retract that. Due to my lack of familiarity with Farsi and the Jalali calendar numerals, I misinterpreted the output during my testing and incorrectly thought it had saved properly.

To be safe I am changing my vote to unsuccessful for now. I highly recommend that someone who better understand Farsi gives this a proper test.

Sorry for the confusion!

@krishnagandhicode If that means that you were not able to test, then please change to "Not tested". Unsuccessful should only be used if a human test fails for a PR or if the PR breaks something.

I have not tested this item.

@krishnagandhicode If that means that you were not able to test, then please change to "Not tested". Unsuccessful should only be used if a human test fails for a PR or if the PR breaks something.

Alright - but According to me this does not work for farsi/jalali calendar.

I have not tested this item.

@krishnagandhicode If that means that you were not able to test, then please change to "Not tested". Unsuccessful should only be used if a human test fails for a PR or if the PR breaks something.

Alright - but According to me this does not work for farsi/jalali calendar.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47626.

My test with Farsi (and the patch applied):

• Open calendar picker
• Select a day
• Manually changing the time in the input directly (not using time selector from calendar picker)
• Save.
• Result: the time edited manually as set in input is stored.

@krishnagandhicode could you explain what according to you, does not work with Farsi?
And did you test it as well with a gregorian calendar (English for example) to compare your result?
Thanks!

Note: the code change is not supposed to affect non-gregorian calendar, so i'm a bit surprized about the result of not working with a Farsi calendar.

@krishnagandhicode could you explain what according to you, does not work with Farsi? And did you test it as well with a gregorian calendar (English for example) to compare your result? Thanks!

Note: the code change is not supposed to affect non-gregorian calendar, so i'm a bit surprized about the result of not working with a Farsi calendar.

I completely agree on that and most probably it's something not okay on my side : (
( Well my test for gregorian calendar was a Successful test)

Okay I will give it another try.

I have tested this item ✅ successfully on 9769b06

RTC

I have tested this item 🔴 unsuccessfully on 9769b06

Final test before merge with JBT and installed fa-IR

• Before PR
  • With en-GB and Gregorian calendar
    • Seen problem in backend for all five date/time-picker Publishing, Featured and Created fields
    • Seen problem in frontend for the two Publishing fields
  • With fa-IR and Jalali (Solar Hijri) calendar
    • Seen problem in backend e.g. in Start Publishing field
      • ⚠️ Another error: if the time is changed in the hour and minute fields, it is saved in the other field instead -> created #47645
• Applied PR with Patch Tester and npm run build:js
  • ✅ With en-GB and Gregorian calendar
    • Backend for all five date/time-picker Publishing, Featured and Created fields are working now
      • Also working is only using date/time-picker or only entering date/time manually
      • Also working is clearing all fields, used is 'Start Punlishing' and 'Created Date' with current date/time
    • Frontend the two plublishing fields are working
      • Also working is only using date/time-picker or only entering date/time manually
  • ✅ With fa-IR and Jalali (Solar Hijri) calendar
    • Backend for all five date/time-picker Publishing, Featured and Created fields are working now
      • Also working is clearing all fields, used is 'Start Punlishing' and 'Created Date' with current date/time
      • The other error #47645 is still present
  • ❌ New error is found, changing hour and minute results in changing the year (e.g. from 2026 to 997)
    • This was not seen before PR and double checked in reverting the PR
    • see screen recording https://github.com/user-attachments/assets/fbdf1038-57be-4f07-a799-a70e42af47fb

Thank you @muhme for this advanced test!
I missed the data-alt-value attribute...
I will come up with an improved update tomorrow adding a date convertion for non-gregorian to populate correctly the data-alt-value.

@muhme @exlemor @brianteeman @richard67 @krishnagandhicode, after Heiko advanced test, an issue was found with datetime stored, not converted to Gregorian SQL format in Jahali calendar.

I've updated the PR to fix that, adding a correct conversion for date.

In the same time, Heiko reported a RTL issue for hour and minute selector #47645 which is not related to this PR, but as i was digging into the code, i've fixed it as well.
The issue is hour and minutes fields were swapped byt line 718 row.insertBefore(minutesCell, hoursCell); in RTL, but when getting the field values, the hour was getting minutes field and vice-versa for the minutes field getting the hour. To fix it, added additionnal check for RTL to reverse hour and minutes childnodes.

So that means this PR will need 3 test contexts:

• In gregorian LTR (primary test process of this PR)
• In RTL (gregorian or not) Note: as @brianteeman mentionned: "the hours:minutes should be displayed exactly the same in both LTR and RTL"
• In Jahali calendar (the date and time should be stored in DB in Gregorian format, but rendered in Jahali calendar in the datetime picker and input field)

I've done many test since yesterday since with this updated PR (LTR, RTL, Gregorian, Jahali) and it seems to fix the 2+1 issues reported).

Thank you for testing back this PR! 👍

Set back to Pending, as code is changed and new tests are required

Set back to Pending, as code is changed and new tests are required

Thanks @muhme 👍

The test instructions are wrong. There is a difference between testing and RTL language such as Hebrew or Arabic and testing with Persian (farsi). Hebrew and Arabic both use the Gregorian calendar but Persian uses the very different jalali calendar. Please don't confuse the two.

I am surprised to hear that there is a problem with time on the jalali calendar as this was tested by native speakers. Unfortunately they are unable to retest at the moment as internet access is not currently available in their country.

The test instructions are wrong. There is a difference between testing and RTL language such as Hebrew or Arabic and testing with Persian (farsi). Hebrew and Arabic both use the Gregorian calendar but Persian uses the very different jalali calendar. Please don't confuse the two.

Thanks Brian, but maybe my English is not perfect. I would be happy if you can help me to improve testing instruction.
I've mentionned "Jahali" for RTL with a eg. before (i think it means example in English, if not, i'm doing this error since a long tiem...), as the issue reported by @muhme is with Jahali calendar.
Of course, i can edit to improve the instruction to add mention of Gregorian calendar with RTL language.

I am surprised to hear that there is a problem with time on the jalali calendar as this was tested by native speakers. Unfortunately they are unable to retest at the moment as internet access is not currently available in their country.
I'm surprised too after @muhme issue report #47645 about RTL issue with Jahali (which is not only for Jahali, but for RTL languages) to not have been catched earlier, as mixing hours and minutes seems a confusing behavior.

But with advanced and thorough testing of this PR, we could potentially fix all of this. ;-)

The test instructions are wrong. There is a difference between testing and RTL language such as Hebrew or Arabic and testing with Persian (farsi). Hebrew and Arabic both use the Gregorian calendar but Persian uses the very different jalali calendar. Please don't confuse the two.

Thanks Brian, but maybe my English is not perfect. I would be happy if you can help me to improve testing instruction.
I've mentionned "Jahali" for RTL with a eg. before (i think it means example in English, if not, i'm doing this error since a long tiem...), as the issue reported by @muhme is with Jahali calendar.
Of course, i can edit to improve the instruction to add mention of Gregorian calendar with RTL language.

I am surprised to hear that there is a problem with time on the jalali calendar as this was tested by native speakers. Unfortunately they are unable to retest at the moment as internet access is not currently available in their country.

I'm surprised too after @muhme issue report #47645 about RTL issue with Jahali (which is not only for Jahali, but for RTL languages) to not have been catched earlier, as mixing hours and minutes seems a confusing behavior.

But with advanced and thorough testing of this PR, we could potentially fix all of this. ;-)

The test instructions are wrong. There is a difference between testing and RTL language such as Hebrew or Arabic and testing with Persian (farsi). Hebrew and Arabic both use the Gregorian calendar but Persian uses the very different jalali calendar. Please don't confuse the two.

Thanks Brian, but maybe my English is not perfect. I would be happy if you can help me to improve testing instruction.
I've mentionned "Jahali" for RTL with a eg. before (i think it means example in English, if not, i'm doing this error since a long tiem...), as the issue reported by @muhme is with Jahali calendar.
Of course, i can edit to improve the instruction to add mention of Gregorian calendar with RTL language.

I am surprised to hear that there is a problem with time on the jalali calendar as this was tested by native speakers. Unfortunately they are unable to retest at the moment as internet access is not currently available in their country.

I'm surprised too after @muhme issue report #47645 about RTL issue with Jahali (which is not only for Jahali, but for RTL languages) to not have been catched earlier, as mixing hours and minutes is a confusing behavior.

But with advanced and thorough testing of this PR, we could potentially fix all of this. ;-)

The test instructions are wrong. There is a difference between testing and RTL language such as Hebrew or Arabic and testing with Persian (farsi). Hebrew and Arabic both use the Gregorian calendar but Persian uses the very different jalali calendar. Please don't confuse the two.

Thanks @brianteeman, maybe my English is not perfect. I would be happy if you can help me to improve testing instruction.
I've mentionned "Jahali" for RTL with a eg. before (i think it means example in English, if not, i'm doing this error since a long tiem...), as the issue reported by @muhme is with Jahali calendar.
Of course, i can edit to improve the instruction to add mention of Gregorian calendar with RTL language.

I am surprised to hear that there is a problem with time on the jalali calendar as this was tested by native speakers. Unfortunately they are unable to retest at the moment as internet access is not currently available in their country.

I'm surprised too after @muhme issue report #47645 about RTL issue with Jahali (which is not only for Jahali, but for RTL languages) to not have been catched earlier, as mixing hours and minutes is a confusing behavior.

But with advanced and thorough testing of this PR, we could potentially fix all of this. ;-)

The test instructions are wrong. There is a difference between testing and RTL language such as Hebrew or Arabic and testing with Persian (farsi). Hebrew and Arabic both use the Gregorian calendar but Persian uses the very different jalali calendar. Please don't confuse the two.

Thanks @brianteeman, maybe my English is not perfect. I would be happy if you can help me to improve testing instruction.
I've mentionned "Jalali" for RTL with a eg. before (i think it means example in English, if not, i'm doing this error since a long tiem...), as the issue reported by @muhme is with Jalali calendar.
Of course, i can edit to improve the instruction to add mention of Gregorian calendar with RTL language.

I am surprised to hear that there is a problem with time on the jalali calendar as this was tested by native speakers. Unfortunately they are unable to retest at the moment as internet access is not currently available in their country.

I'm surprised too after @muhme issue report #47645 about RTL issue with Jalali (which is not only for Jalali, but for RTL languages) to not have been catched earlier, as mixing hours and minutes is a confusing behavior.

But with advanced and thorough testing of this PR, we could potentially fix all of this. ;-)

The test instructions are wrong. There is a difference between testing and RTL language such as Hebrew or Arabic and testing with Persian (farsi). Hebrew and Arabic both use the Gregorian calendar but Persian uses the very different jalali calendar. Please don't confuse the two.

Thanks @brianteeman, maybe my English is not perfect. I would be happy if you can help me to improve testing instruction.
I've mentionned "Jalali" for RTL with a eg. before (i think it means example in English, if not, i'm doing this error since a long time...), as the issue reported by @muhme is with Jalali calendar.
Of course, i can edit to improve the instruction to add mention of Gregorian calendar with RTL language.

I am surprised to hear that there is a problem with time on the jalali calendar as this was tested by native speakers. Unfortunately they are unable to retest at the moment as internet access is not currently available in their country.

I'm surprised too after @muhme issue report #47645 about RTL issue with Jalali (which is not only for Jalali, but for RTL languages) to not have been catched earlier, as mixing hours and minutes is a confusing behavior.

But with advanced and thorough testing of this PR, we could potentially fix all of this. ;-)

I've updated the testing instructions to prevent confusion.

I have tested this item ✅ successfully on 521376d

verified the bug in arabic and farsi
confirmed this pr fixes the bug in both arabic and farsi

I have tested this item ✅ successfully on 521376d

verified the bug in arabic and farsi
confirmed this pr fixes the bug in both arabic and farsi