[#47628] - Ensure all page content is contained by landmarks in installed frontend modules 'Main Menu ' and 'Login Form'
- Pending
- Medium
- Build: 6.2-dev
- # 47628
- Diff
- obuisard:6.2-dev
User tests: Successful: Unsuccessful:
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
During Joomla's installation, Main Menu and Login Form are instantiated by default in the sidebar of the frontend. However, the modules classes take the default (which is 'div') while is should be 'aside'.
Testing Instructions
On a fresh install, in the browser, on the frontend, open a developer tool such as 'axe DevTools' (browser extension) and run a scan for WCAG 2.1 AA.
Actual result BEFORE applying this Pull Request
The scan returns moderate issues:
All page content is contained by landmarks.
Expected result AFTER applying this Pull Request
The scan does not return issues.
Note that
is the correct semantic container for a sidebar module, even if it moves to the bottom on small screens (semantic HTML is about meaning, not visual placement).Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql |
Sorry I see now that PR was for atum not cassiopeia. However you should read the comments and discussion there. aside is definitely not the correct landmark for a menu
PS just putting a module inside a landmark does not make it accessible. It has to be the correct landmark but automated testing can not test for that so you will get a pass no matter what landmark you use
PS just putting a module inside a landmark does not make it accessible. It has to be the correct landmark but automated testing can not test for that so you will get a pass no matter what landmark you use
If I change aside to nav for the main menu, that seems all right. Do you agree to use 'nav' instead Brian @brianteeman ?
Note that the menu itself is using the class 'nav'. But that's not a tag...)
the menu really should be a nav and the login aside but I am not on the a11y team and they should really comment
With the menu it is complicated ... this PR #33978 moved the nav element from the template (Cassiopeia) to the module, but only for the collapsible version, because we are following Bootstrap's navbar ... We should have added another layout for the non-collapsible navigation including the nav element too. If you now change the tag in the module in the sidebar you get a nav looking like a card ...
Didnt this already get merged in 6.1 with #45988