[#47477] - [5.4] DRAFT Remove image fallback in HTMLHelper.php
- Pending
- Medium
- Build: 5.4-dev
- # 47477
- Diff
- chinmayi-sudo:patch-1
User tests: Successful: Unsuccessful:
Summary of Changes
This PR removes the unused image fallback from "HTMLHelper.php".
Previously, when "$text" was empty, an image fallback ("tooltip.png") was generated using "static::image()". This fallback is no longer required as the image is deprecated and not used in the current codebase.
Testing Instructions
- Open a Joomla page where tooltips are used
- Trigger a tooltip without text
- Check:
- No broken image is displayed
- Tooltip still works correctly
- No UI issues appear
Expected result
- No fallback image should appear
- UI should remain unaffected
Actual result
- Fallback image logic removed successfully
Documentation Changes Required
No
AI Policy
I confirm that this pull request follows Joomla's AI contribution guidelines.
#47477
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
What if someone use own image?
This PR breaks such possibility.
Thank you for the feedback. I have updated the PR description as per the template.
As this code is not used in the core of joomla the test instructions are not complete
the code is obviously wrong
@brianteeman Thank you for the feedback. I understand that the change may not be correct and the testing instructions are insufficient. I will review the issue again and update the PR accordingly.
It is expected that at a very minimum BEFORE you start that you can replicate the problem. Until you can do that then you are not able to verify that your proposed code will fix something.
@chinmayi-sudo Thank you for your contribution!
As already stated please use the standard PR template to format the description. It is much easier to find the information given with each PR on the same place in the the same format.
We will set this PR to DRAFT for now. Please feel free to update it within the next two weeks and mark it as ready for review again — otherwise, we may need to close it.
Additionally, the continuous integration currently reports PHP code style issues that need to be addressed. Alle CI checks needs to be passed before to mark the PR as ready for review.
| Title |
|
||||||
@chinmayi-sudo Please use our Pull Request template and do not remove the pre-defined headings but fill in the missing information instead. This includes:
Thank you! We appreciate your contribution to Joomla!
If you don't do this within a reasonable time of 2-3 weeks, this PR will be closed.