RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar LadySolveig
LadySolveig
25 Mar 2026

Pull Request resolves # .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

The AI took the fun approach here #47467 when generating the test plugin by pointing out that the page argument is missing, resulting in inconsistent test results for the legacy modules compared to the new article module.

grafik
if ($event->getPage() !== null) {
    return;
}

This would work at the moment in the new Article Module, but nowhere else as all others have an offset or 0 default.
As it is more consistent with the rest of the codebase to include the page argument and give it value 0 instead of null as we do everywhere else, here is the PR for that.

Testing Instructions

Code Review

Actual result BEFORE applying this Pull Request

Unconsistent

Expected result AFTER applying this Pull Request

Consistent

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar LadySolveig LadySolveig - open - 25 Mar 2026
avatar LadySolveig LadySolveig - change - 25 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Mar 2026
Category Modules Front End
avatar ramalama ramalama - test_item - 25 Mar 2026 - Tested successfully
avatar ramalama
ramalama - comment - 25 Mar 2026

I have tested this item ✅ successfully on a7fe11e

Test via Code Review successful


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47476.

avatar joomdonation joomdonation - test_item - 9 May 2026 - Tested successfully
avatar joomdonation
joomdonation - comment - 9 May 2026

I have tested this item ✅ successfully on a7fe11e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47476.

avatar joomdonation
joomdonation - comment - 9 May 2026

I have tested this item ✅ successfully on a7fe11e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47476.

avatar joomdonation joomdonation - change - 9 May 2026
Status Pending Ready to Commit
avatar joomdonation
joomdonation - comment - 9 May 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47476.

avatar joomdonation
joomdonation - comment - 9 May 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47476.

avatar richard67 richard67 - change - 9 May 2026
Labels Added: RTC bug PR-5.4-dev
avatar richard67 richard67 - change - 9 May 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-05-09 17:01:34
Closed_By richard67
avatar richard67 richard67 - close - 9 May 2026
avatar richard67 richard67 - merge - 9 May 2026
avatar richard67
richard67 - comment - 9 May 2026

Thanks @LadySolveig for this PR and @ramalama and @joomdonation for testing/review.

Add a Comment

Login with GitHub to post a comment