User tests: Successful: Unsuccessful:
Pull Request resolves # .
The AI took the fun approach here #47467 when generating the test plugin by pointing out that the page argument is missing, resulting in inconsistent test results for the legacy modules compared to the new article module.
if ($event->getPage() !== null) {
return;
}
This would work at the moment in the new Article Module, but nowhere else as all others have an offset or 0 default.
As it is more consistent with the rest of the codebase to include the page argument and give it value 0 instead of null as we do everywhere else, here is the PR for that.
Code Review
Unconsistent
Consistent
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Modules Front End |
I have tested this item ✅ successfully on a7fe11e
Test via Code Review successful
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47476.