User tests: Successful: Unsuccessful:
…exists
Pull Request resolves #42384 .
Fixes a bug where TinyMCE ignores a custom CSS file configured in the plugin unless a .min.css version is also present. If only the non minified file exists, joomla incorrectly falls back to the default editor stylesheet.
This change adds a simple fallback to load the original file when no minified version is available, while still preferring .min.css files when they exist.
The custom css file is ignored unless a corresponding .min.css file exists and renaming the file to myeditor.min.css makes it work
The configured custom css file loads correctly even without a .min.css version and even if a minified version exists, it is still preferred
Please select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Front End Plugins |
| Labels |
Added:
PR-5.4-dev
|
||
I have tested this item ✅ successfully on 7094f8a
I have tested this item ✅ successfully on 7094f8a
I have successfully tested this during the PR Testing Group. Thanks @adarshdubey03
I have tested this item ✅ successfully on 7094f8a
Created file and see resulting change
| Status | Pending | ⇒ | Ready to Commit |
RTC
This doesn’t break the default Joomla behavior for assets? (Ie try the minified if exists then fallback to non minified for non debug and inverted logic for debug).
@richard67 this is probably a breaking change
This doesn’t break the default Joomla behavior for assets? (Ie try the minified if exists then fallback to non minified for non debug and inverted logic for debug). @richard67 this is probably a breaking change
@dgrammatiko When checking the code change I don't see that it breaks the default logic.
The existing checks remain unchanged: https://github.com/joomla/joomla-cms/pull/47478/changes#diff-a152c697ea1292d07592f1375d1c2545fd49637dd73f1336130f136c119fa851L107-L114
And the new fallback is added after these checks: https://github.com/joomla/joomla-cms/pull/47478/changes#diff-a152c697ea1292d07592f1375d1c2545fd49637dd73f1336130f136c119fa851R115-R118
So the fallback only appears when we haven't used the unminified file due to debug mode and the minified file does not exist.
Am I missing something?
This doesn’t break the default Joomla behavior for assets?
It is only for TinyMCE code,
if the editor continue to work with debug "On" and "Off" then all fine
| Labels |
Added:
RTC
bug
|
||
✅ Final test before merge with JBT
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-04-01 15:50:54 |
| Closed_By | ⇒ | muhme |
Thank you very much @adarshdubey03 for your contribution. Thanks to @dgrammatiko, @richard67 and @Fedik for your support. Thanks to @krishnagandhicode, @brianteeman, @exlemor and @ThomasFinnern for testing.
I have tested this item ✅ successfully on 7094f8a
This works as expected!
TESTERS make sure you have Debug System turned off - If its on Joomla's asset manager overrides things and forces the raw .css file to load completely masking the issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47478.