RTC bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar adarshdubey03
adarshdubey03
26 Mar 2026

…exists

Pull Request resolves #42384 .

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

Fixes a bug where TinyMCE ignores a custom CSS file configured in the plugin unless a .min.css version is also present. If only the non minified file exists, joomla incorrectly falls back to the default editor stylesheet.
This change adds a simple fallback to load the original file when no minified version is available, while still preferring .min.css files when they exist.

Testing Instructions

  1. Create a custom css file in the active site template, (for eg - media/templates/site/cassiopeia/css/myeditor.css)
  2. Add a rule such as : p.red { color: red; }
  3. Go to System -> Plugins -> Editor -> TinyMCE
  4. Open the active set and fill myeditor.css in the custom class css field
  5. Create an article using TinyMCE
  6. Add some content and apply the class

Actual result BEFORE applying this Pull Request

The custom css file is ignored unless a corresponding .min.css file exists and renaming the file to myeditor.min.css makes it work

Expected result AFTER applying this Pull Request

The configured custom css file loads correctly even without a .min.css version and even if a minified version exists, it is still preferred

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar adarshdubey03 adarshdubey03 - open - 26 Mar 2026
avatar adarshdubey03 adarshdubey03 - change - 26 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Mar 2026
Category Front End Plugins
avatar adarshdubey03 adarshdubey03 - change - 26 Mar 2026
Labels Added: PR-5.4-dev
avatar krishnagandhicode krishnagandhicode - test_item - 27 Mar 2026 - Tested successfully
avatar krishnagandhicode
krishnagandhicode - comment - 27 Mar 2026

I have tested this item ✅ successfully on 7094f8a

This works as expected!

TESTERS make sure you have Debug System turned off - If its on Joomla's asset manager overrides things and forces the raw .css file to load completely masking the issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47478.

avatar brianteeman brianteeman - test_item - 27 Mar 2026 - Tested successfully
avatar brianteeman
brianteeman - comment - 27 Mar 2026

I have tested this item ✅ successfully on 7094f8a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47478.

avatar exlemor exlemor - test_item - 27 Mar 2026 - Tested successfully
avatar exlemor
exlemor - comment - 27 Mar 2026

I have tested this item ✅ successfully on 7094f8a

I have successfully tested this during the PR Testing Group. Thanks @adarshdubey03


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47478.

avatar ThomasFinnern ThomasFinnern - test_item - 27 Mar 2026 - Tested successfully
avatar ThomasFinnern
ThomasFinnern - comment - 27 Mar 2026

I have tested this item ✅ successfully on 7094f8a

Created file and see resulting change


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47478.

avatar richard67 richard67 - change - 27 Mar 2026
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 27 Mar 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47478.

avatar dgrammatiko
dgrammatiko - comment - 29 Mar 2026

This doesn’t break the default Joomla behavior for assets? (Ie try the minified if exists then fallback to non minified for non debug and inverted logic for debug).
@richard67 this is probably a breaking change

avatar richard67
richard67 - comment - 29 Mar 2026

This doesn’t break the default Joomla behavior for assets? (Ie try the minified if exists then fallback to non minified for non debug and inverted logic for debug). @richard67 this is probably a breaking change

@dgrammatiko When checking the code change I don't see that it breaks the default logic.

The existing checks remain unchanged: https://github.com/joomla/joomla-cms/pull/47478/changes#diff-a152c697ea1292d07592f1375d1c2545fd49637dd73f1336130f136c119fa851L107-L114

And the new fallback is added after these checks: https://github.com/joomla/joomla-cms/pull/47478/changes#diff-a152c697ea1292d07592f1375d1c2545fd49637dd73f1336130f136c119fa851R115-R118

So the fallback only appears when we haven't used the unminified file due to debug mode and the minified file does not exist.

Am I missing something?

avatar Fedik
Fedik - comment - 29 Mar 2026

This doesn’t break the default Joomla behavior for assets?

It is only for TinyMCE code,
if the editor continue to work with debug "On" and "Off" then all fine

avatar muhme muhme - change - 1 Apr 2026
Labels Added: RTC bug
avatar muhme
muhme - comment - 1 Apr 2026

✅ Final test before merge with JBT

  • Disabled 'Debug System'
  • Seen custom CSS is only working as .min.css
  • Applied PR with Patch Tester
    • Non-minified CSS is working
    • Minified CSS is working
    • If both are present, the minimised CSS is used
avatar muhme muhme - close - 1 Apr 2026
avatar muhme muhme - merge - 1 Apr 2026
avatar muhme muhme - change - 1 Apr 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-04-01 15:50:54
Closed_By muhme
avatar muhme
muhme - comment - 1 Apr 2026

Thank you very much @adarshdubey03 for your contribution. Thanks to @dgrammatiko, @richard67 and @Fedik for your support. Thanks to @krishnagandhicode, @brianteeman, @exlemor and @ThomasFinnern for testing.

Add a Comment

Login with GitHub to post a comment