RTC NPM Resource Changed bug PR-5.4-dev Pending

User tests: Successful: Unsuccessful:

avatar krishnagandhicode
krishnagandhicode
24 Mar 2026

Pull Request resolves #39060

  • I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.

Summary of Changes

PR fixes the rotate tab behavior in media Manager where the manual angle input gets reset to 0 after applying rotation.

The fix keeps the user entered value in the angle field after rotation is applid.


Note:
This PR focuses on the reported bug #39060 value reset to 0.
There is also a broader UX behavior where manual rotation is triggered by change/blur events. That means if the value is unchangeed, no new rotation action is triggered. To keep this bug fix focused, I suggest handling that separately as a follow-up improvement.

For that a possible way(I can think of) is adding an explicit apply action(button) for manual angle input. IDK if that is to be considered as an feature - that is likely an enhancement and can be discussed in a separate issue/PR.

Also for the case of using arrows with cursor that also needs attention.


Testing Instructions

Administrator > content > Media.
use any image in edit mode.
go to the Rotate tab.
In the Angle field, type a value (for example 44) and click anywhere outside the field.
Verify:

Actual result BEFORE applying this Pull Request

The image rotates but the manual Angle input field is reset to 0

Before.mp4

Expected result AFTER applying this Pull Request

After entering a manual angle and applying rotation, the image rotates and the angle field keeps the entered value.

After.mp4

Link to documentations

Please select:

  • Documentation link for guide.joomla.org:

  • No documentation changes for guide.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar krishnagandhicode krishnagandhicode - open - 24 Mar 2026
avatar krishnagandhicode krishnagandhicode - change - 24 Mar 2026
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Mar 2026
Category JavaScript Repository NPM Change
avatar exlemor exlemor - test_item - 25 Mar 2026 - Tested successfully
avatar exlemor
exlemor - comment - 25 Mar 2026

I have tested this item ✅ successfully on 614254e

I have tested it successfully. Thanks @krishnagandhicode!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47462.

avatar krishnagandhicode krishnagandhicode - change - 26 Mar 2026
The description was changed
avatar krishnagandhicode krishnagandhicode - edited - 26 Mar 2026
avatar adarshdubey03 adarshdubey03 - test_item - 27 Mar 2026 - Tested successfully
avatar adarshdubey03
adarshdubey03 - comment - 27 Mar 2026

I have tested this item ✅ successfully on 614254e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47462.

avatar richard67 richard67 - change - 27 Mar 2026
Status Pending Ready to Commit
Labels Added: NPM Resource Changed bug PR-5.4-dev
avatar richard67
richard67 - comment - 27 Mar 2026

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47462.

avatar muhme muhme - change - 1 Apr 2026
Labels Added: RTC
avatar muhme
muhme - comment - 1 Apr 2026

✅ Final test before merge with JBT

  • Seen Angle 0 after rotating
  • PR applied with Patch Tester and npm run build:js
  • The image rotates and the angle field keeps the entered value, the buttons are still working
avatar muhme muhme - change - 1 Apr 2026
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2026-04-01 13:27:24
Closed_By muhme
avatar muhme muhme - close - 1 Apr 2026
avatar muhme muhme - merge - 1 Apr 2026
avatar muhme
muhme - comment - 1 Apr 2026

Thank you very much @krishnagandhicode for your contribution. Thanks to @adarshdubey03 and @exlemor for testing.

avatar krishnagandhicode
krishnagandhicode - comment - 1 Apr 2026

Thanks for the merge, and thanks to everyone who helped test : )

Add a Comment

Login with GitHub to post a comment