User tests: Successful: Unsuccessful:
Pull Request resolves #47451.
Fixes wrong implementation of element removal in Form->load with overwrite=false.
mod_demo47451_1.0.0.zip (System → Install → Extensions).main-top), assigned to all pages.Red FAIL box:
FAIL — bug #47451 present:
titleappears 2× in the form XML (expected 1×) and
the rendered form shows the label “Label from BASE xml (must NOT win)” — the
merge overrode the existing field in the wrong direction.
The dumped form XML contains a second <fieldset name="demo"> with a duplicate
<field name="title">.
Green PASS box:
PASS — the existing field was kept (
titleappears 1× in the form XML, label:
“Label from VARIANT xml (must win)”).
The rendered fieldset shows title once with the VARIANT label, and the new
extra field from the base XML is still added correctly.
Form from a variant XML that defines the field title$form->load($baseXml, false) that also definestitle (label “Label from BASE xml (must NOT win)”) plus a new field extra.com_content's CategoryModel::preprocessForm() doesPlease select:
Documentation link for guide.joomla.org:
No documentation changes for guide.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
| Category | ⇒ | Libraries |
| Title |
|
||||||
mod_demo47451_1.0.0.zip
I created a minimal module extension to be used for testing.
I will also update testing instruction above accordingly.
I have tested this item ✅ successfully on bc9a641
I have tested this item ✅ successfully on bc9a641
I have tested this item ✅ successfully on bc9a641
Tested with the given module, red before and green afterwards. No unusual Joomla or PHP log messages.
I have tested this item ✅ successfully on bc9a641
Tested with the given module, red before and green afterwards. No unusual Joomla or PHP log messages.
| Status | Pending | ⇒ | Ready to Commit |
RTC
RTC
| Labels |
Added:
RTC
bug
PR-5.4-dev
|
||
The proposal was discussed by maintainers, whether there should be a clear, consistent code (but it can be merged as how it is) or whether the proposal is too resouce-expensive simply to remove a single item, given that a web server has limited resources. The RMs have decided to merge the PR as is. Thank you all.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-08-29 08:29:08 |
| Closed_By | ⇒ | muhme |
Thank you very much @ramalama for your contribution. Thanks to @joomdonation and @HLeithner for review. Thank you @rbuelund for testing.
new PR instead of #47452