[#47448] - [5.4] use logical top corner radius for RTL/LTR consistency
- Fixed in Code Base
- 1 Apr 2026
- Medium
- Build: 5.4-dev
- # 47448
- Diff
- krishnagandhicode:fix-38354-media-rtl
User tests: Successful: Unsuccessful:
Pull Request resolves #38354
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
In LTR this already looked correct, but in RTL one outer top corner could stay rounded because the styles relied on physical left/right radius rules.
I updated the media field SCSS to include logical corner radius propertes so the same result is applied correctly in both (LTR and RTL)
Testing Instructions
Open an admin form that contains a Media Field:
you can find it at:
administrator > content > article > new/any existing article > go to images and links.
now you see the field Intro Image
Well You can observe the issue even without selecting an image, but for clearer visual verification on both sides, select any image first.
Now
In LTR (e.g English):
Confirm the media preview box and the input/button row connect cleanly.
Verify the top corners of the row are square (no rounded gap at the top edge). (zoom in to see closely)
Switch to an RTL(arabic, persian) this admin language.
Reload the same form and verify the same visual behavior:
No unexpected rounded top corner appears on the outer edge.
Actual result BEFORE applying this Pull Request
Already seen above.
Expected result AFTER applying this Pull Request
In both LTR and RTL, the media field row sits under the preview box and both top corners are rendered as intended (square)
Recording.2026-03-23.021535.mp4
Also test:
before: #47448 (comment)
After:
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
I have tested this item ✅ successfully on b318afc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47448.
@brianteeman Is browser support sufficient here?
yes absolutely - sorry didnt have time to test the pr myself yet
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
bug
PR-5.4-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47448.
It is still not perfect in both LTR and RTL mode when NO image has been selected yet and it would be good if that could be fixed at the same time
It is still not perfect in both LTR and RTL mode when NO image has been selected yet and it would be good if that could be fixed at the same time
@krishnagandhicode Could you fix that with this PR here, too?
| Labels |
Added:
RTC
|
||
| Category | Repository NPM Change | ⇒ | JavaScript Repository NPM Change |
| Status | Ready to Commit | ⇒ | Pending |
Back to pending as the PR has received changes.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47448.
@exlemor @adarshdubey03 Could you test again? And could you also test the case when no image has been selected yet so the "Clear" button is not there? Thanks in advance.
@drmenzelit Could you review the SCSS changes? Maybe something can be simplified?
@exlemor @adarshdubey03 Could you test again? And could you also test the case when no image has been selected yet so the "Clear" button is not there? Thanks in advance.
Thanks @richard67
Basically also test that:
With no image selected so clear is obv. not present, and select now has the right corner styling(cureved bottom radius) for both rtl and ltr.
added in test Instructions too :-
I have tested this item ✅ successfully on fad9919
I have re-tested this successfully including the no image selected use case. Thanks @brianteeman, @richard67 and @krishnagandhicode!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47448.
I have tested this item ✅ successfully on fad9919
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47448.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47448.
✅ Final test before merge with JBT
- Installed Urdu
- PR grafted using the full package
- on macOS tested all the combinations of RTL and LTR, w/ and w/o image, dark and light mode with Firefox, Safari, Chrome and Edge
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2026-04-01 10:33:34 |
| Closed_By | ⇒ | muhme |
Thank you very much @krishnagandhicode for your contribution. Thanks to @brianteeman and @richard67 for your support. Thanks to @adarshdubey03, @exlemor and @brianteeman for testing.
Thanks for the merge, and thanks to everyone who helped with testing.
I have tested this item ✅ successfully on b318afc
I have successfully tested this. Thanks @krishnagandhicode!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/47448.