[#47449] - [5.4] Fix duplicate term insertion crash in com_finder indexer
- Pending
- Medium
- Build: 5.4-dev
- # 47449
- Diff
- narang24:fix-finder-duplicate
User tests: Successful: Unsuccessful:
Pull Request resolves #47447
- I read the Generative AI policy and my contribution is either not created with the help of AI or is compatible with the policy and GNU/GPL 2 or later.
Summary of Changes
Replaced INSERT INTO with INSERT IGNORE INTO in com_finder indexer to prevent duplicate term insertion errors from terminating the indexing process.
Testing Instructions
Index content where two items share a normalised term (e.g. "Sueño Stereo" that strips to an already existing term).
Actual result BEFORE applying this Pull Request
Index creation may terminate with a duplicate entry error for idx_term_language.
Expected result AFTER applying this Pull Request
Duplicate entries are ignored and indexing completes successfully.
Link to documentations
Please select:
-
Documentation link for guide.joomla.org:
-
No documentation changes for guide.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
Besides my previous comment, I don’t think this is the right fix. It would circumvent the issue but not fix the root cause.
„Insert ignore“ is MySQL and MariaDB syntax. On PostgreSQL this causes an SQL syntax error. As Joomla also supports PostgreSQL, this PR cannot be accepted as it is.
See https://www.postgresql.org/docs/current/sql-insert.html
This might also be the reason why system tests with PostgreSQL are failing.